Setting "keywords" removes any existing keywords for ticket(s)

[Morris]

Example: ticket #52 has keywords set to "test ticket blah". If I use the BatchModifyPlugin capability to set the keywords field for ticket #52, the existing keywords values were removed and the new ones set.

Now, it could just be a matter of differing expectations, but I think in this particular case the plugin should check the value of the keywords field and decide what to do accordingly: any text input should be appended to the existing keywords value (with requisite space inserted); if and only if the input value is empty would the existing keyword value be removed.

Just my $0.02...

Note: I'm using BatchModifyPlugin on Trac 0.11

[Jenn Drummond]

I wholeheartedly agree with your expectation. I'd love to use this plugin, but little stuff like this is holding me back. So make that $0.04. :)

[sir.maestro@…]

We would also appreciate this fix, because now keywords in this plugin are for us useless. Thank you

[ogiesen]

I think the new keywords should not simply be appended to the text field but rather merged with the existing ones, i.e. when one of the newly added keywords already exists on the ticket I would not want to have it duped after the batch modification...

[CuriousCurmudgeon]

(In [7531]) refs #2311

• The new keywords are now merged with the existing keywords on each ticket being modified.

[CuriousCurmudgeon]

An exception is thrown if the user does not submit any new keywords.

[CuriousCurmudgeon]

(In [7536]) refs #2311

• Assuming that users are always submitting new keywords is bad. Added a check to make sure there are new keywords before attempting to merge the new and old.