Modify

Opened 7 years ago

Closed 4 years ago

#2311 closed defect (fixed)

Setting "keywords" removes any existing keywords for ticket(s)

Reported by: gt4329b Owned by: CuriousCurmudgeon
Priority: normal Component: BatchModifyPlugin
Severity: minor Keywords: keywords
Cc: gt4329b@… Trac Release: 0.11

Description

Example: ticket #52 has keywords set to "test ticket blah". If I use the BatchModifyPlugin capability to set the keywords field for ticket #52, the existing keywords values were removed and the new ones set.

Now, it could just be a matter of differing expectations, but I think in this particular case the plugin should check the value of the keywords field and decide what to do accordingly: any text input should be appended to the existing keywords value (with requisite space inserted); if and only if the input value is empty would the existing keyword value be removed.

Just my $0.02...

Note: I'm using BatchModifyPlugin on Trac 0.11

Attachments (0)

Change History (11)

comment:1 Changed 6 years ago by Jennifer Drummond <jenn@…>

I wholeheartedly agree with your expectation. I'd love to use this plugin, but little stuff like this is holding me back. So make that $0.04. :)

comment:2 Changed 5 years ago by sir.maestro@…

We would also appreciate this fix, because now keywords in this plugin are for us useless.
Thank you

comment:3 Changed 5 years ago by ogiesen

I think the new keywords should not simply be appended to the text field but rather merged with the existing ones, i.e. when one of the newly added keywords already exists on the ticket I would not want to have it duped after the batch modification...

comment:4 Changed 4 years ago by CuriousCurmudgeon

  • Owner changed from ashwin_phatak to CuriousCurmudgeon
  • Status changed from new to assigned

comment:5 Changed 4 years ago by CuriousCurmudgeon

(In [7531]) refs #2311

  • The new keywords are now merged with the existing keywords on each ticket being modified.

comment:6 Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:7 Changed 4 years ago by CuriousCurmudgeon

  • Resolution fixed deleted
  • Status changed from closed to reopened

An exception is thrown if the user does not submit any new keywords.

comment:8 Changed 4 years ago by CuriousCurmudgeon

  • Status changed from reopened to new

comment:9 Changed 4 years ago by CuriousCurmudgeon

  • Status changed from new to assigned

comment:10 Changed 4 years ago by CuriousCurmudgeon

(In [7536]) refs #2311

  • Assuming that users are always submitting new keywords is bad. Added a check to make sure there are new keywords before attempting to merge the new and old.

comment:11 Changed 4 years ago by CuriousCurmudgeon

  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from CuriousCurmudgeon. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.