Modify

Opened 7 years ago

Closed 7 years ago

#2336 closed defect (fixed)

Nondeterministic depgraph generation

Reported by: kjdavies Owned by: kjdavies
Priority: normal Component: MasterTicketsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

If you generate the same depgraph image repeatedly, you can get different images. All I have seen are *correct*, but the arrangement varies.

If you order the nodes when you select them, that should result in deterministic depgraph generation

Attachments (1)

masterticketsplugin-kjdavies20071228.diff (8.1 KB) - added by kjdavies 7 years ago.
Patch file fixing #2332, #2333, #2336

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by kjdavies

  • Owner changed from coderanger to kjdavies

comment:2 Changed 7 years ago by kjdavies

I have a fix for this in my local code (replace overloads on Node.gt and node.lt with Node.blocks() and Node.blockedby(), then call those functions instead)

Overloading gt and lt may be clever and look nice, but it makes for code that's nonobvious to readers and messes with sorting semantics. Once I removed the gt and lt overloads I as able to sort the nodes and edges, which gave me a consistent .dot file, which dot was able to render consistently.

Changed 7 years ago by kjdavies

Patch file fixing #2332, #2333, #2336

comment:3 Changed 7 years ago by coderanger

  • Resolution set to fixed
  • Status changed from new to closed

Fixed as of [2960].

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.