Modify

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#2458 closed defect (invalid)

Downloader admin nav items overlay main trac nav items (0.11)

Reported by: axton.grams@… Owned by: peca
Priority: normal Component: TracDownloaderPlugin
Severity: normal Keywords: MESSAGE
Cc: Ny Trac Release: 0.10

Description

Env Info:

  • Trac 0.11dev-r6396
  • Apache/2.2.6
  • Linux 2.6.9-023stab044.4-enterprise
  • mod_python-3.2.10
  • subversion 1.4.2

Summary: When using the Downloader admin pages, the navigation items for the plugin overlay the main navigation bar. This has to do with the placement of the plugin nav items within the html. I don't know enough about cs or what the direction is with genshi, but here is a diff against the raw html to address the issue.

Attachments (2)

screenshot_bad.png (41.7 KB) - added by axton.grams@… 7 years ago.
screenshot_bad
screenshot_withpatch.png (43.3 KB) - added by axton.grams@… 7 years ago.
screenshot with patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by axton.grams@…

This html diff is against a page generated from revision 3129.

[root@arswiki html]# diff -ubB --ignore-all-space downloader_broken.htm downaloder.htm
--- downloader_broken.htm 2008-01-22 18:28:16.000000000 -0500
+++ downaloder.htm 2008-01-22 18:28:01.000000000 -0500
@@ -41,11 +41,13 @@

</div>

<div id="main">

<div id="ctxtnav" class="nav">

  • <h2>Context Navigation</h2>

+ <h2>Downloader Navigation</h2>

<ul>

+ <li class="first"><a href="a.b/projects/arapi/admin/general/downloader/files" class="choosen">Files Admin</a></li><li><a href="a.b/projects/arapi/admin/general/downloader/stats">Stats Admin</a></li><li class="last"><a href="a.b/projects/arapi/admin/general/downloader/settings">Settings</a></li>

</ul>

  • <hr>

+<hr />

</div>

+

<div id="content" class="admin">

<h1>Administration</h1>
<div id="tabs">

@@ -91,13 +93,6 @@

</div>
<div id="tabcontent">

-<div id="ctxtnav" class="nav nav_admin">

  • <h2>Downloader Navigation</h2>
  • <ul>

-

  • <li class="first"><a href="a.b/projects/arapi/admin/general/downloader/files" class="choosen">Files Admin</a></li><li><a href="a.b/projects/arapi/admin/general/downloader/stats">Stats Admin</a></li><li class="last"><a href="a.b/projects/arapi/admin/general/downloader/settings">Settings</a></li>
  • </ul>

-</div>

<h2>Downloader admin</h2>

<form id="category" class="addnew" method="post" enctype="multipart/form-data"><div><input name="FORM_TOKEN" value="98cea1da8608efbfbbdb73f5" type="hidden"></div>

<fieldset>

Changed 7 years ago by axton.grams@…

screenshot_bad

Changed 7 years ago by axton.grams@…

screenshot with patch

comment:2 in reply to: ↑ description Changed 7 years ago by peca

Hello!

I feel little lost, please write me exact version of Trac you're using (on screen shot there is 10.4) and exact type of downloader (if it's version for 0.11 or 0.10). I've seen something like is on your screen shot when I started to remake version for Trac 0.10 to Trac 0.11b1. So I think this shouldn't happen.

Thank you for more info!
Peca

Replying to axton.grams@gmail.com:

Env Info:

  • Trac 0.11dev-r6396
  • Apache/2.2.6
  • Linux 2.6.9-023stab044.4-enterprise
  • mod_python-3.2.10
  • subversion 1.4.2

Summary: When using the Downloader admin pages, the navigation items for the plugin overlay the main navigation bar. This has to do with the placement of the plugin nav items within the html. I don't know enough about cs or what the direction is with genshi, but here is a diff against the raw html to address the issue.

comment:3 Changed 7 years ago by axton.grams@…

Exact version, per the footer, is 'Powered by Trac 0.11dev-r6396'

You can check out out at http://arswiki.org/projects/arapi

The downloader I checked out is from trac-hacks.org/svn/tracdownloaderplugin/0.10/

Axton

comment:4 in reply to: ↑ description Changed 7 years ago by peca

Ok, so first, if you didn't do so, try version trac-hacks.org/svn/tracdownloaderplugin/0.11/. I think that should be better because I think that r6396 is newer (???) than 0.11b1 in which I'm testing Downloader for 0.11.

Replying to axton.grams@gmail.com:

Env Info:

  • Trac 0.11dev-r6396
  • Apache/2.2.6
  • Linux 2.6.9-023stab044.4-enterprise
  • mod_python-3.2.10
  • subversion 1.4.2

Summary: When using the Downloader admin pages, the navigation items for the plugin overlay the main navigation bar. This has to do with the placement of the plugin nav items within the html. I don't know enough about cs or what the direction is with genshi, but here is a diff against the raw html to address the issue.

comment:5 Changed 7 years ago by axton.grams@…

  • Resolution set to invalid
  • Status changed from new to closed

Thanks so much. I though I checked last night and didn't see a 0.11 tag for downloader. The 0.11 tag fixed the issue.

Thanks again,
Axton Grams

comment:6 Changed 6 years ago by Kionsards

  • Cc Ny added
  • Keywords MESSAGE added

Cash Advance Loans at <a href='http://testslosa.iwebsource.com/everyone-approved-no-teletrack-1-hour-payday-loans-10.html '>everyone approved no teletrack 1 hour payday loans</a> Solve your money worries

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from peca. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.