Ticket #2474 (closed defect: worksforme)

Opened 5 years ago

Last modified 1 year ago

Include with non-standard port does not work

Reported by: gruenhagen@onlinehome.de Assigned to: rjollos
Priority: normal Component: IncludeMacro
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

Include of any http-url via an port other than 80 seems not to work at all. Is there any way to go arround?

Regards Thomas

Attachments

Change History

01/20/11 10:10:51 changed by jholg

See ticket:4743 for patch that adds support for usage of non-standard http ports for included resources, among other things.

06/06/12 09:24:34 changed by rjollos

  • owner changed from coderanger to rjollos.
  • status changed from new to assigned.

This seems to be working fine with the latest trunk, r11627.

06/06/12 09:25:24 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to worksforme.
  • summary changed from Include with non standard port does not work to Include with non-standard port does not work.

Also, ticket #4743 doesn't seem to have any changes for specifying a port.

(follow-up: ↓ 5 ) 06/26/12 19:55:25 changed by jholg

Not true. #4743 adds working support to actually have working intertrac support and include http resources, plus it correctly uses urlopen to access such resources which deals with any non-standard port by itself.

I must admit that I haven't tried it with a setup where an included intertrac site serves from a different port, though - can't really remember if this should work or not right now.

I use this on a day-to-day basis without any glitches (I wrote the patch so my opinion is probably biased ;-)). Note that the original IncludeMacro source can only really include (X)HTML snippets if the include source is not wiki:, although if broken (X)HTML gets included then the include might work due to the parser suddenly presenting parts of the included page to the macro that it normally wouldn't even allow.

I'd love to see #4743 changes go into the official macro - let me know if I can help.

(in reply to: ↑ 4 ) 06/27/12 02:03:07 changed by rjollos

Replying to jholg:

plus it correctly uses urlopen to access such resources which deals with any non-standard port by itself.

Thanks for the explanation. I will looking into adding the patch now. Testers welcome :)

Add/Change #2474 (Include with non-standard port does not work)




Change Properties
Action