Modify

Opened 7 years ago

Closed 6 years ago

#2500 closed defect (fixed)

applying batch modifications does nothing

Reported by: tsella@… Owned by: ashwin_phatak
Priority: high Component: BatchModifyPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.11

Description

trac 0.11b1, Genshi from trunk r789, user has admin rights and TICKET_BATCH_MODIFY.

submitting batch modification does nothing. any suggestions?

Attachments (0)

Change History (12)

comment:1 Changed 7 years ago by nate@…

I'm having this exact same problem. Running Trac 0.11b1. The batch modify interface works fine, but when I submit updates, nothing happens ... no changes are made to the selected tickets. Nothing in the trac.log either.

comment:2 Changed 6 years ago by anonymous

  • Priority changed from normal to high
  • Severity changed from normal to critical

Running Trac 0.11b1, if I put this in trac.ini:

[components]
batchmod.* = enabled
trac.ticket.query.* = disabled

then a query yields "No handler matched request to /query", and if I do this:

[components]
batchmod.* = enabled
trac.ticket.query.* = enabled

then the UI "works" but no update is done to the db.

Any clues would be most helpful as this plugin is essential for being able to work with large numbers of tickets.

comment:3 Changed 6 years ago by anonymous

Happens to us as well, running 0.11b1 and genshi trunk.

UI only shows up if we don't disable the custom query:

[components]
batchmod.* = enabled
#trac.ticket.query.* = disabled

And then nothing happens when we batch modify.

comment:4 Changed 6 years ago by conny@…

I experience the same problem. Varying the ![components]-settings does not seem to make any difference at all.

Right not the plugin is just plain useless in 0.11*.

comment:5 Changed 6 years ago by lburgess@…

I'm running into the same issue, Trac v0.11b1 and nothing happens when I apply changes to a batch of tickets.

comment:6 Changed 6 years ago by marcus@…

Second this. And we really like this plugin!

Whoooo has a wishlist on amazon? I could most probably get someone a couple of books for this... ;-)

comment:7 Changed 6 years ago by anonymous

  • Severity changed from critical to blocker

comment:8 Changed 6 years ago by AlexGreen

It appears it has something to do with "selectedTickets" being empty.
My ugly hack to get it work for 11b1 is to change web_ui.py:

@@ -61,30 +61,11 @@
                         values['status'] = 'assigned'
                     values[name] = req.args.get('bmod_value_' + name)
 
-        selectedTickets = req.args.get('selectedTickets')
-        selectedTickets = isinstance(selectedTickets, list) and selectedTickets or selectedTickets.split(',')
-        if not selectedTickets:
-            raise TracError, 'No Tickets selected'
-        
-        for id in selectedTickets:
-            if id in tickets:
-                t = Ticket(self.env, id) 
-                t.populate(values)
-                t.save_changes(req.authname, comment)
+        for id in tickets:
+            t = Ticket(self.env, id) 
+            t.populate(values)
+            t.save_changes(req.authname, comment)

comment:9 Changed 6 years ago by AlexGreen

Just realized that applying a patch from #2312 appears to fix the problem and does not require any hacks.

comment:10 Changed 6 years ago by conny@…

I applied batchmod-jquery1.2.patch and yeah it seemed to fix the "nothing happens" bug...

But then I realized, as already reported in #2762, that it still does not allow you to batch update Status and/or Resolution :-/

comment:11 Changed 6 years ago by mtibout@…

Could someone provide instructions on how to apply patches on the installed batchmod python egg?
Thanks

comment:12 Changed 6 years ago by dgynn

  • Resolution set to fixed
  • Status changed from new to closed

This should be fixed with the latest install instructions for 0.11 and the patch applied in changeset:3916. Reopen the ticket if there are still problems

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from ashwin_phatak. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.