Ticket #2653 (closed enhancement: fixed)

Opened 7 months ago

Last modified 2 weeks ago

RFE: Re-Use of screenshot IDs

Reported by: izzy Assigned to: Blackhex
Priority: normal Component: ScreenshotsPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.10

Description

If some image was deleted, the ID is lost. The idea behind this seems to be clear to me (re-using the ID could result in old references to this ID getting re-activated with the wrong target). Still there should be a possibility to re-use the ID, e.g. if a screenshot was accidentally deleted.

Idea of implementation:

  • in the matrix view, next to the "Add" button an input could be placed (for the ID to replace), together with an additional checkbox (confirm replace) which is by default always unchecked. If used, on submit there should be an additional warning (Javascript popup or additional page in between)
  • selecting "screenshots/1" (where "1" is a deleted ID) either by typing in the URL or by following some broken link, a user with SCREENSHOTS_ADMIN should not only receive the error message, but the possibility to upload a new screenshot.

Well, Radek - looks like I'm keeping you busy, huh? ;)

Attachments

Change History

02/28/08 10:33:35 changed by Blackhex

  • status changed from new to assigned.

I'm affraid that inserting screenshot with missing ID won't be possible since IDs are assigned by DB backend and I'm not aware that there is a way to request certain ID. At least not a common for sqlite, PostgreSQL and MySQL database.

I'll consult DB documentation about this.

Generating own IDs to accomplish this is IMHO too intrusive change for such minor feature.

Nevertheless, replacing existing screenshot could be done.

Well, Radek - looks like I'm keeping you busy, huh? ;)

No worry, but be aware that I'm working on Trac's plugins only in spare time and when I have a taste for it.

09/22/08 04:51:57 changed by Blackhex

  • status changed from assigned to closed.
  • resolution set to fixed.

First bullet is obsoleted by possibility of screenshot replacement in r4314. Second bullet is implemented there too.

09/22/08 07:00:35 changed by izzy

I'm really impressed - will checkout ASAP to have it available! :) Guess you now have goot reason to bump the version number to 0.6 <g> Thank you!

09/22/08 07:30:04 changed by Blackhex

I'll shift version to 0.6 with DB schema update needed for #2656 which I'm currently working on. I'll backport all these new features to 0.10 at once when all opened RFE tickets will be implemented. Thanks for your patience.

09/22/08 07:42:56 changed by izzy

That's great news. I will look forward to that. Finally my fault - why did I open so many tickets ;)

Thank you again for the great work you are doing! I love ScreenshotsPlugin ;)

Add/Change #2653 (RFE: Re-Use of screenshot IDs)




Change Properties
Action