Ticket #2685 (new defect)

Opened 2 years ago

Last modified 3 weeks ago

shortrev_len does not work

Reported by: xlyz at tiscali d ot it Assigned to: hvr
Priority: normal Component: GitPlugin
Severity: normal Keywords:
Cc: lkraav Trac Release: 0.11

Description

Trac-0.11b1 and gitplugin (3275). no matter how I set shortrev_len rev sha remain 40 caracter long

Attachments

pass_repo.patch (3.4 kB) - added by roadrunner on 08/17/09 10:46:45.
A small preparatory change (same patch as in #5351)
rev_len.patch (12.5 kB) - added by roadrunner on 08/17/09 10:47:55.
Add rev_len config option and shorten all displayed revisions to that length
r_rev.patch (0.8 kB) - added by roadrunner on 08/17/09 10:48:39.
Recognize r<rev> wiki syntax too

Change History

03/05/08 01:47:48 changed by thatch

I took a glance at this too with 0.10, 0.11b1, and trunk (with the respective plugins from t-h) and it looks the same to me on a very simple git db (or whatever you call it). Adding some print statements seems to indicate that short_rev is only called for displaying the changeset page, but that might be be clouded by the cache.

03/21/09 20:46:21 changed by Robin

I'd like to use this feature too, but it doesn't work with GitPlugin trunk and Trac 0.11.3.

04/27/09 19:01:25 changed by deisner@gmail.com

Same here, doesn't work with GitPlugin and Trac 0.11.4.

05/18/09 09:42:07 changed by patrick232

same here

GitPlugin (the latest)
Trac 0.12multirepos-r8178
git 1.6.2.4

06/16/09 12:22:52 changed by anonymous

Same here. This is so annoying that it (a) clutters the code browser and I can't read the commit messages and (b) it keeps me switching from Redmine (which I would really like to do ;-) ).

(follow-up: ↓ 7 ) 08/17/09 10:44:50 changed by roadrunner

shortrev_len works as designed; however, there seems to be some confusion as to what it does: it configures the length of the shortened revision number displayed in things like the diff (column heads) and the annotated file view (revision for each line).

I'm attaching three patches, the second one of which does the main job of adding a new rev_len option which controls the length of all revisions displayed (except for those covered by shortrev). This also makes trac recognize shortened revs in the wiki syntax. The third patch adds support for recognizing the r<rev> wiki syntax too. The patches must be applied in the order I'm attaching them.

08/17/09 10:46:45 changed by roadrunner

  • attachment pass_repo.patch added.

A small preparatory change (same patch as in #5351)

08/17/09 10:47:55 changed by roadrunner

  • attachment rev_len.patch added.

Add rev_len config option and shorten all displayed revisions to that length

08/17/09 10:48:39 changed by roadrunner

  • attachment r_rev.patch added.

Recognize r<rev> wiki syntax too

(in reply to: ↑ 6 ) 08/26/09 22:17:25 changed by tomster

Replying to roadrunner:

I'm attaching three patches, the second one of which does the main job of adding a new rev_len option which controls the length of all revisions displayed (except for those covered by shortrev). This also makes trac recognize shortened revs in the wiki syntax. The third patch adds support for recognizing the r<rev> wiki syntax too. The patches must be applied in the order I'm attaching them.

any reason why these patches haven't been merged? i'm reluctant to patch my installation (it's enough dealing with the python2.4 compatibility patch...)

just asking...

03/02/10 23:51:18 changed by lkraav

  • cc set to lkraav.

cc-ing, looking to get this fixed too.

Add/Change #2685 (shortrev_len does not work)




Change Properties
Action