Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#2830 closed defect (fixed)

Main plugin page layout broken in Safari

Reported by: ryan@… Owned by: osimons
Priority: normal Component: CustomFieldAdminPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

In Safari, the 'Add Custom Field' on the main page of the plugin, does not correctly float to the right of the list of custom fields - instead the list of custom fields appears beneath it.

As this worked fine in Firefox, checking the code with Firebug, I found that there is a missing </div> for the 'Add Custom Field' box which needs putting in to correct the layout problem.

The additional </div> should be placed after the existing </div> on line 77 of the 'customfieldadmin.cs' file.

Attachments (0)

Change History (3)

comment:1 Changed 6 years ago by osimons

Right, don't have a test setup for the 0.10 version anymore, but staring at the code it does look like a closing </div> is missing after line 68. Could you please test this change?

  • 0.10/customfieldadmin/templates/customfieldadmin.cs

     
    6666   <legend>Add Custom Field:</legend> 
    6767   <div class="field"> 
    6868    <label>Name:<br /><input type="text" name="name" id="name" /></label> 
     69   </div> 
    6970   <div class="field"> 
    7071    <label>Type:<br /><select name="type" id="type"> 
    7172    <option value="text">Text</option> 

comment:2 Changed 6 years ago by ryan@…

  • Resolution set to fixed
  • Status changed from new to closed

Yes, that fixes it, thank you.

comment:3 Changed 6 years ago by osimons

(In [3428]) CustomFieldAdminPlugin Minor 0.10 template fix.

Closes #2830

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from osimons. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.