Modify

Opened 6 years ago

Closed 6 years ago

#2853 closed defect (fixed)

Page parsing silently fails when using quotes with the [forum:] handler

Reported by: KevinGabbert Owned by: Blackhex
Priority: low Component: DiscussionPlugin
Severity: major Keywords:
Cc: kevin@… Trac Release: 0.10

Description

I like to link to a report so I can have alternate text in a link, rather than something like: {22}

so I do the following:

[forum:../report/22 Report name]

problem is, if you have quotes in that link, Trac blows up and FAILS to error! not rendering any text, buttons, or even the rest of the page.

Paste this scary code into your Trac. See what happens:

[forum:../report/22 Report name with "Quotes"]

if you are editing a wiki page, the only way you can edit the page after that is if you add ?action=edit to the end of the url

This text will also break a ticket. I don't know a workaround for that, however.

I haven't tried it in a forum, but I bet that may break it too.

perhaps this is an error with Trac, but I figured I would start reporting it here.

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by KevinGabbert

FYI,

the following:

[wiki:../report/21 this "is" a test]

will work without causing any problems

comment:2 Changed 6 years ago by KevinGabbert

Forgot to add this. Using plugin version tracdiscussion 0.5

comment:3 Changed 6 years ago by Blackhex

  • Priority changed from high to low
  • Severity changed from critical to major
  • Status changed from new to assigned

Yes, it's Trac issue. I'll check what does this caues with Discussion plugin in lately.

comment:4 Changed 6 years ago by Blackhex

  • Resolution set to fixed
  • Status changed from assigned to closed

First, why are you using [wiki:<name>] ir [forum:<id>] for refering to reports? There is [report:<id>] for that.

Secondly, there was a minor bug in DiscussionPlugin with that. Macro label is setted to title attribute of A element when refered forum/topic/message does not exist and this breaks validness of page. r3464 fixes this for 0.10 branch by stripping all " characters. 0.11 branch contains some local changes which are not yet finished so fix is not commited there.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.