Ticket #2882 (closed defect: fixed)

Opened 8 months ago

Last modified 6 months ago

trac-link source: broken

Reported by: anonymous Assigned to: proofek
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords: trac-links
Cc: Trac Release: 0.10

Description (Last modified by proofek)

When the Peerreview Plugin is installed are trac-links to sourcefiles are broken.

In the Wiki-text: [source:<repository-element> alternative text]

Before installing PeerReviewPlugin:
http://<trac-server>:<trac-port>/<project-name>/browser/<repository-element>

After installing PeerReviewPlugin:
http://<trac-server>:<trac-port>/<project-name>/peerReviewBrowser/<repository-element>

Versions used:

python 2.5.1
trac 0.10.4
svn 1.4.3
PeerReviewPlugin TracCodeReview-2.0dev

Note:
Disabling the sub-component peerReviewBrowser (while keeping all other sub-components enabled) switches back to the expected behavior.

Attachments

mylyn-context.zip (0.8 kB) - added by proofek on 06/04/08 18:14:03.
mylyn/context/zip

Change History

04/09/08 05:25:40 changed by anonymous

  • priority changed from high to normal.
  • severity changed from major to normal.

Looking a little more into it i've found that peerReviewBrowser.py is an extender of IWikiSyntaxProvider. It wants to reformat links for 'browser', 'repos' and 'source'.

As i don't know what the intention of this is, i've commented out the 'source' part. 

--- peerReviewBrowser.py.orig
+++ peerReviewBrowser.py
@@ -242,7 +242,7 @@
  
     def get_link_resolvers(self):
         return [('repos', self._format_link),
-                ('source', self._format_link),
+        #        ('source', self._format_link),
                 ('browser', self._format_link)]
  
     def _format_link(self, formatter, ns, path, label):

Now trac-links starting with source: behave as expected. The browser: and repos: links still point to this plugin.

For what the repos: and browser: links are is unclear to me.

I hope that this is a fix or at least a workaround without to many unwanted side effects.

06/04/08 17:42:49 changed by proofek

  • status changed from new to assigned.
  • description changed.

06/04/08 18:11:10 changed by proofek

It actually break the wiki completly in trac 0.11. I think peerReviewBrowser shouldn't implement IWikiSyntaxProvider at all. Removing.

06/04/08 18:14:02 changed by proofek

  • status changed from assigned to closed.
  • resolution set to fixed.

Will merge those changes to 0.11 and trunk as well.

06/04/08 18:14:03 changed by proofek

  • attachment mylyn-context.zip added.

mylyn/context/zip

Add/Change #2882 (trac-link source: broken)




Change Properties
Action