Opened 6 years ago

Closed 6 years ago

#2882 closed defect (fixed)

trac-link source: broken

Reported by: anonymous Owned by: proofek
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords: trac-links
Cc: Trac Release: 0.10

Description (last modified by proofek)

When the Peerreview Plugin is installed are trac-links to sourcefiles are broken.

In the Wiki-text: [source:<repository-element> alternative text]

Before installing PeerReviewPlugin:

After installing PeerReviewPlugin:

Versions used:

python 2.5.1
trac 0.10.4
svn 1.4.3
PeerReviewPlugin TracCodeReview-2.0dev

Disabling the sub-component peerReviewBrowser (while keeping all other sub-components enabled) switches back to the expected behavior.

Attachments (1) (843 bytes) - added by proofek 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by anonymous

  • Priority changed from high to normal
  • Severity changed from major to normal

Looking a little more into it i've found that is an extender of IWikiSyntaxProvider. It wants to reformat links for 'browser', 'repos' and 'source'.

As i don't know what the intention of this is, i've commented out the 'source' part.


    old new  
    243243    def get_link_resolvers(self): 
    244244        return [('repos', self._format_link), 
    245                 ('source', self._format_link), 
     245        #        ('source', self._format_link), 
    246246                ('browser', self._format_link)] 
    248248    def _format_link(self, formatter, ns, path, label): 

Now trac-links starting with source: behave as expected.
The browser: and repos: links still point to this plugin.

For what the repos: and browser: links are is unclear to me.

I hope that this is a fix or at least a workaround without to many unwanted side effects.

comment:2 Changed 6 years ago by proofek

  • Description modified (diff)
  • Status changed from new to assigned

comment:3 Changed 6 years ago by proofek

It actually break the wiki completly in trac 0.11. I think peerReviewBrowser shouldn't implement IWikiSyntaxProvider at all. Removing.

comment:4 Changed 6 years ago by proofek

  • Resolution set to fixed
  • Status changed from assigned to closed

Will merge those changes to 0.11 and trunk as well.

Changed 6 years ago by proofek


Add Comment

Modify Ticket

as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from proofek. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.