cache_size being limited to 25

[John A. Barbuto]

Hi,

While troubleshooting a performance issue, I found that the LDAP cache_size can't go higher than 25, despite what is set in trac.ini. Here's the relevant code in lines 71 and 187 of api.py:

self._cache_size = min(25, int(self.config.get('ldap', 'cache_size', '100')))
self._cache_size = min(25, int(cache_size))

Why have a default of 100 for cache_size when it's being forced down to 25? A limit for sanity checking makes sense, but I think it should be much higher. Fixing this in our installation made our Trac significantly faster.

[Emmanuel Blot]

Very true.

I have used the LdapPlugin for a very long time, and it definitely needs some improvements and fixes.

As I plan to use again this plugin in our environment, I hope to have some time to work on it.

[Jodok Batlogg]

it should say max(...)instead of min(...)