Modify

Opened 6 years ago

Closed 6 years ago

#3137 closed enhancement (fixed)

Fix tests and include functional tests

Reported by: s0undt3ch Owned by: pacopablo
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: tests
Cc: mgood, coderanger Trac Release: 0.11

Description

Here's a patch to fix tests.

  • acct_mgr/tests/db.py

     
    2121class _BaseTestCase(unittest.TestCase): 
    2222    def setUp(self): 
    2323        #self.basedir = os.path.realpath(tempfile.mkdtemp()) 
    24         self.env = EnvironmentStub() 
     24        self.env = EnvironmentStub(enable=['trac.*', 'acct_mgr.*']) 
    2525        self.env.config.set('account-manager', 'password_store', 
    2626                            'SessionStore') 
    2727        self.store = SessionStore(self.env) 

Attachments (1)

fix_and_include_functional_tests.patch (31.3 KB) - added by s0undt3ch 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by s0undt3ch

  • Owner changed from mgood to pacopablo

comment:2 Changed 6 years ago by s0undt3ch

  • Cc mgood coderanger added
  • Severity changed from blocker to normal
  • Summary changed from Fix tests to Fix tests and include functional tests
  • Type changed from defect to enhancement

I'm including you guys in CC in order to check the tests I'm about to attach, and to let me know if you have more to include, and, of course, to see if one of you guys check's in the patch.

P.S.: It's a mercurial patch, use patch -p1 < ....

Changed 6 years ago by s0undt3ch

comment:3 Changed 6 years ago by s0undt3ch

If you find it good to check in I can provide a svn patch, I'd just like to keep my local acct_mgr as pristine as possible.

comment:4 Changed 6 years ago by pacopablo

  • Resolution set to fixed
  • Status changed from new to closed

(In [3832])

  • Apply patch from s0undt3ch removing email verification for anonymous users. Refs #442
  • Apply patch from s0undt3ch implementing functional tests and fixing existing tests. Closes #3137.

Thanks for the patches s0undt3ch

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.