Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3202 closed defect (fixed)

svn urls has bogus first line for table

Reported by: k0s Owned by: k0s
Priority: normal Component: SvnUrlsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

For any subdirectory, the first entry .., for the parent directory contains a bogus svn url link. The link points to the right place, but it is in the "Last Changes" column and should either be moved to the right place or removed

see (e.g.)

http://trac.openplans.org/trac/browser/23Screens/wp-admin

Attachments (0)

Change History (3)

comment:1 follow-up: Changed 6 years ago by extemporalgenome@…

This is because the .. column has a colspan attribute hard coded to be 5. The best method would be to submit a patch to vanilla trac that looks at the number of columns in the header, and sets the colspan dynamically. From there, it would be a simple fix (via negation in an xpath expression) to have SvnUrlsPlugin avoid transforming that row.

comment:2 Changed 6 years ago by k0s

  • Resolution set to fixed
  • Status changed from new to closed

(In [4112]) unmark the colspan attribute from the "../" link; fixes #3202

comment:3 in reply to: ↑ 1 Changed 6 years ago by k0s

Replying to extemporalgenome@gmail.com:

This is because the .. column has a colspan attribute hard coded to be 5. The best method would be to submit a patch to vanilla trac that looks at the number of columns in the header, and sets the colspan dynamically. From there, it would be a simple fix (via negation in an xpath expression) to have SvnUrlsPlugin avoid transforming that row.

i did this by just unmarking the colspan attribute on this entry (see r4112); ideally, the colspan should be reset on the subsequent entry, but i punted on this for now.

Add Comment

Modify Ticket

Action
as closed The owner will remain k0s.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.