Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#3206 closed defect (fixed)

[PATCH] Edit Wiki Page content and tag

Reported by: catalin.balan@… Owned by: athomas
Priority: normal Component: TagsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

  • edit tags and content at the same time
  • after saving, only the tag was altered but the content remained unchanged.

The attached patch fixes that.

Thank you

Attachments (1)

tags.th.patch (703 bytes) - added by catalin.balan@… 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by catalin.balan@…

comment:1 Changed 6 years ago by athomas

  • Resolution set to fixed
  • Status changed from new to closed

(In [3877]) Fix Wiki tag saving semantics. Fixes #3206.

comment:2 Changed 6 years ago by anonymous

Also see #3145

comment:3 Changed 6 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

(in reply to http://trac-hacks.org/ticket/3145#comment:4)

I should have re-opened #3206 instead, even though they seem related.

At least it is not working for me. As you can see, the embedded patch *removes* some code added by [3877]. Either way, please add the setup.cfg file for the sake of those who run the trunk version.

Please investigate the patch in http://trac-hacks.org/ticket/3145#comment:3

comment:4 Changed 6 years ago by athomas

What behaviour are you seeing? The same as this bug? Or is it slightly different?

comment:5 Changed 6 years ago by jamesyonan

I am seeing this issue as well with TagsPlugin 0.6 and Trac 0.11. When I attempt to create a new page (with new content) and tag it at the same time, only the tag is persisted in the DB, while the page remains in an uncreated state with the content I entered discarded.

comment:6 Changed 6 years ago by izzy

Same is happening if you update content and tags of a wiki page at the same time: Tags are updated, changes to the contents are lost. Using the latest trunk versions of both, trac and the TagsPlugin.

comment:7 Changed 6 years ago by roh

i am seeing this too. on creation one cannot add a tag without loosing the content

comment:8 Changed 5 years ago by anonymous@…

ack: same problem. is there no fix out there?

comment:9 Changed 5 years ago by otaku42

I can confirm that this bug occured with the combination of Trac 0.11.6 and TracTagsPlugin v0.6 (r3117). cbalan's patch works fine, though, and I can confirm that it fixes this bug for the mentioned combination.

comment:10 follow-up: Changed 5 years ago by otaku42

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [7372]) Fix a bug that, when trying to create a new wiki page with one or more tags, discarded the wiki page content. Thanks to cbalan for the patch. Fixes #3206.

comment:11 in reply to: ↑ 10 Changed 5 years ago by otaku42

Replying to otaku42:

(In [7372]) Fix a bug that, when trying to create a new wiki page with one or more tags, discarded the wiki page content. Thanks to cbalan for the patch. Fixes #3206.

Guess I had a bad day:

I accidentally committed stuff to the tagged release v0.6 rather than to trunk, which of course was wrong. I'll thus roll back r7372. No need to re-apply the patch to trunk, however, as the issue has been fixed there before.

Add Comment

Modify Ticket

Action
as closed The owner will remain athomas.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.