Ticket #3222 (assigned defect)

Opened 5 years ago

Last modified 1 year ago

[Patch] Allow group names to have *some* upper-case letters

Reported by: dean.harding@dload.com.au Assigned to: rjollos (accepted)
Priority: normal Component: PrivateTicketsPlugin
Severity: minor Keywords: groups
Cc: Trac Release: 0.10

Description

Line 125 of policy.py has the following code:

    if subject in groups and action.islower() and action not in groups

This assumes that group names are all lower-case, but that's not necessarily true -- the help text on the "permissions" page in Admin says (emphasis added):

"Note that Subject or Group names can't be all upper cased, as this is reserved for permission names."

Some of our group names have upper case characters in them, and so I had to change line 125 to read:

    if subject in groups and not action.isupper() and action not in groups

That change made it work nicely with our setup. Great plugin, by the way -- extremely useful :-)

Attachments

Change History

12/04/10 00:06:56 changed by rjollos

  • summary changed from Group names can have upper-case letters to Allow group names to have *some* upper-case letters.

#5165 closed as a duplicate.

12/04/10 01:18:53 changed by rjollos

#6278 closed as a duplicate.

02/02/11 18:11:53 changed by rjollos

  • owner changed from coderanger to rjollos.
  • status changed from new to assigned.
  • summary changed from Allow group names to have *some* upper-case letters to [Patch] Allow group names to have *some* upper-case letters.

02/02/11 18:19:15 changed by rjollos

(In [9814]) Allow group names to have *some* upper case characters. Thanks to Dean Harding for the patch. Fixes #3222.

04/16/12 01:27:09 changed by rjollos

The fix in [9814] is consistent with similar code in the Trac source for DefaultPermissionStore.get_user_permissions:

04/16/12 02:14:09 changed by rjollos

This ticket will be left open for feedback and resolved with milestone 2.1 (#9964)


Add/Change #3222 ([Patch] Allow group names to have *some* upper-case letters)




Change Properties
Action