Modify

Opened 6 years ago

Closed 4 months ago

Last modified 4 months ago

#3222 closed defect (fixed)

[Patch] Allow group names to have *some* upper-case letters

Reported by: dean.harding@… Owned by: rjollos
Priority: normal Component: PrivateTicketsPlugin
Severity: minor Keywords: groups
Cc: Trac Release: 0.10

Description

Line 125 of policy.py has the following code:

    if subject in groups and action.islower() and action not in groups

This assumes that group names are all lower-case, but that's not necessarily true -- the help text on the "permissions" page in Admin says (emphasis added):

"Note that Subject or Group names can't be all upper cased, as this is reserved for permission names."

Some of our group names have upper case characters in them, and so I had to change line 125 to read:

    if subject in groups and not action.isupper() and action not in groups

That change made it work nicely with our setup. Great plugin, by the way -- extremely useful :-)

Attachments (0)

Change History (9)

comment:1 Changed 4 years ago by rjollos

  • Summary changed from Group names can have upper-case letters to Allow group names to have *some* upper-case letters

#5165 closed as a duplicate.

comment:2 Changed 4 years ago by rjollos

#6278 closed as a duplicate.

comment:3 Changed 4 years ago by rjollos

  • Owner changed from coderanger to rjollos
  • Status changed from new to assigned
  • Summary changed from Allow group names to have *some* upper-case letters to [Patch] Allow group names to have *some* upper-case letters

comment:4 Changed 4 years ago by rjollos

(In [9814]) Allow group names to have *some* upper case characters. Thanks to Dean Harding for the patch. Fixes #3222.

comment:5 Changed 2 years ago by rjollos

The fix in [9814] is consistent with similar code in the Trac source for DefaultPermissionStore.get_user_permissions:

Last edited 4 months ago by rjollos (previous) (diff)

comment:6 Changed 2 years ago by rjollos

This ticket will be left open for feedback and resolved with milestone 2.1 (#9964)

comment:7 Changed 14 months ago by rjollos

  • Status changed from assigned to new

comment:8 Changed 8 months ago by rjollos

  • Status changed from new to assigned

comment:9 Changed 4 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.