Modify

Opened 6 years ago

Closed 4 years ago

#3615 closed enhancement (fixed)

[Patch] Improvements for Xref action

Reported by: daniel Owned by: retracile
Priority: normal Component: AdvancedTicketWorkflowPlugin
Severity: normal Keywords:
Cc: datallah Trac Release: 0.11

Description (last modified by retracile)

I've made some enhancements to the xref action including:

  1. Verification that the target ticket exists.
  2. Including the comment change on the local ticket with the original save (so it appears in the change email and doesn't corrupt the ticket cnums)
  3. Sending a change email for the target ticket.

Attachments (1)

adv_ticket_workflow_xref_fixes.patch (3.7 KB) - added by datallah 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by datallah

comment:1 Changed 6 years ago by datallah

  • Cc datallah added

comment:2 Changed 6 years ago by hju@…

I'm facing the same problems.

I think we will try the patch.

Hope this will be included in a future release.

comment:3 Changed 5 years ago by anonymous

chang the patch, by adding a second except clause.



            try:
                xticket = model.Ticket(self.env, ticketnum)
            except ResourceNotFound, e:
                #put in preview mode to prevent ticket being saved
                req.args['preview'] = True
                add_warning(req, "Unable to cross-reference Ticket #%s (%s)." % (ticketnum, e.message))
                return {}
            except ValueError, e:
                #put in preview mode to prevent ticket being saved
                req.args['preview'] = True
                add_warning(req, "Unable to cross-reference Ticket #%s (%s).>%s< is not a number." % (ticketnum, e.message, ticketnum))
                return {}

comment:4 Changed 5 years ago by rjollos

  • Summary changed from Improvements for Xref action to [Patch] Improvements for Xref action

comment:5 Changed 5 years ago by retracile

  • Description modified (diff)

(fixed formatting of description)

comment:6 Changed 4 years ago by retracile

  • Resolution set to fixed
  • Status changed from new to closed

While it breaks the intent of the customizable workflow interface, it does improve the behaviour. Modified version of the patch applied in [9958]. Thanks!

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.