Modify

Opened 6 years ago

Closed 22 months ago

Last modified 22 months ago

#3695 closed defect (fixed)

Picture Upload in "Preferences - My Profile"

Reported by: mail@… Owned by: cbalan
Priority: normal Component: UserManagerPlugin
Severity: normal Keywords: template
Cc: ejucovy, rjollos Trac Release: 0.11

Description

When i select a picture in "Preferences - My Profile" an click on "Save changes", the picture will not be uploaded.

Attachments (0)

Change History (12)

comment:1 Changed 6 years ago by cbalan

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 6 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

This still does not work. The outputted form still lacks the enctype="multipart/form-data" property which prevents files from being uploaded. This is with version 0.4 installed today using easy_install.

comment:3 Changed 6 years ago by cbalan

Can you please provide trac and genshi version please ?

comment:4 Changed 6 years ago by anonymous

Trac:  	        0.11
Python: 	2.5.2 (r252:60911, Oct 5 2008, 19:42:18) [GCC 4.3.2]
setuptools: 	0.6c9
SQLite: 	3.5.9
pysqlite: 	2.4.1
Genshi: 	0.5
mod_python: 	3.3.1
Pygments: 	0.10
Subversion: 	1.5.1 (r32289)
jQuery:	        1.2.3

this is on Ubuntu using the standard versions in packages

comment:5 Changed 5 years ago by tekknokrat

Seems this issue is still open with Trac-0.11.2.1.

Can't find any relevant error messages in DEBUG log. Seems like the file submit is ignored when saving.

comment:6 Changed 4 years ago by lkraav

this operation just worked for me:

System Information
Trac: 	        0.11.6
Python: 	2.4.3 (#1, Sep 3 2009, 15:37:37) [GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
setuptools: 	0.6c11
SQLite: 	3.3.6
pysqlite: 	1.1.7
Genshi: 	0.5.1
mod_wsgi: 	4.0 (WSGIProcessGroup WSGIApplicationGroup %{GLOBAL})
FullBlog: 	0.1.1-r7622
jQuery:	        1.2.6

comment:7 Changed 3 years ago by anonymous

hi have the same problem on 0.11.1

Maybe it's javascript issue can you help please?

comment:8 Changed 3 years ago by uray

patch to fix this issue:

Index: 0.11/tracusermanager/templates/prefs_um_profile.html
===================================================================
--- 0.11/tracusermanager/templates/prefs_um_profile.html	(revision 10578)
+++ 0.11/tracusermanager/templates/prefs_um_profile.html	(working copy)
@@ -4,10 +4,10 @@
 <html xmlns="http://www.w3.org/1999/xhtml"
       xmlns:py="http://genshi.edgewall.org/"
       xmlns:xi="http://www.w3.org/2001/XInclude">
+	<xi:include href="prefs.html" />
     <py:match path="form[@id='userprefs']">
 		<form py:attrs="select('@*')" enctype="multipart/form-data">${select("*|text()")}</form>
     </py:match>
-	<xi:include href="prefs.html" />
  	<head>
    		<title>${_('My Profile')}</title>
 	</head>

comment:9 Changed 2 years ago by ejucovy

  • Cc ejucovy added

comment:10 Changed 2 years ago by ejucovy

uray's patch in comment:8 works for me. Using trac 0.13-dev (trunk) @11017 and usermanager plugin from svn trunk@11434. Thanks uray!

comment:11 Changed 22 months ago by hasienda

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [12152]) UserManagerPlugin: Correct [4262] to get picture upload finally working, closes #3695.

This patch has been kindly provided by uray more than one year ago.
Because I promised cbalan to assist a bit, this is the least I can do.
Sorry for taking so much time.

comment:12 Changed 22 months ago by hasienda

  • Cc rjollos added
  • Keywords template added

Because of ejucovy's test feedback I expect this to work even on Trac-1.0 now.

Btw, the changed template has ugly white spacing, both blanks and tabs mixed seemingly random. Would love to not touch that code much more. Please note, that the decision is almost settled to get unique UserManager functionality back into AccountManager core, ultimately depreciating the separate development. This will be the time to clean all that up.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from cbalan. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.