Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#3777 closed defect (fixed)

template should include 'package_data' by default

Reported by: k0s Owned by: k0s
Priority: normal Component: TracPluginTemplateScript
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

In order to avoid issues like th:#3758, the template should include an appropriate package_data section in setup.py. Ideally, this would be appropriately populated with e.g. templates, htdocs, etc.

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by k0s

  • Status changed from new to assigned

comment:2 Changed 6 years ago by k0s

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4389]) include package_data by default, fixes #3777

comment:3 Changed 5 years ago by martin_s

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from enhancement to defect

The package_data entry must also exists in the setup.py file of TracPluginTemplateScript itself, otherwise the template directory is not installed and paster create fails.

Please add the following:

  • tracplugintemplatescript/0.11/setup.py

     
    1515      url='http://trac-hacks.org/wiki/k0s', 
    1616      license='GPL', 
    1717      packages=find_packages(exclude=['ez_setup', 'examples', 'tests']), 
     18      package_data={'':  
     19        [ 'template/+package+/*/*', 'template/+package+/*.py_tmpl', 'template/*.py_tmpl' ]}, 
    1820      include_package_data=True, 
    1921      zip_safe=False, 
    2022      install_requires=[ 'PasteScript', ], 

comment:4 Changed 5 years ago by k0s

(In [6953]) include package data, refs #3777

comment:5 follow-up: Changed 5 years ago by k0s

  • Resolution set to fixed
  • Status changed from reopened to closed

thanks for the patch; applied in r6953 ; god i hate setuptools

comment:6 in reply to: ↑ 5 ; follow-up: Changed 5 years ago by martin_s

Replying to k0s:

thanks for the patch; applied in r6953 ; god i hate setuptools

:-) Took me a while to find the correct values for package_data it does not take a directory itself. :-(

comment:7 in reply to: ↑ 6 Changed 5 years ago by k0s

Replying to martin_s:

Replying to k0s:

thanks for the patch; applied in r6953 ; god i hate setuptools

:-) Took me a while to find the correct values for package_data it does not take a directory itself. :-(

Yeah, that's why its annoying. :( Thanks again!

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from k0s. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.