Ticket #3836 (new enhancement)

Opened 5 years ago

Last modified 4 months ago

[PATCH] Disable gridmodify until explicitly enabled

Reported by: shez@starfangled.net Assigned to: rjollos
Priority: normal Component: GridModifyPlugin
Severity: normal Keywords:
Cc: jonathan.trackhacks@jghp.net, falkb Trac Release: 0.11

Description (Last modified by rjollos)

Hi,

GridModifyPlugin is almost very useful to us, unfortunately certain reports we use (for example those from the TimingAndEstimationPlugin) look pretty nasty when it is enabled.

This would be a non problem if reports and queries had an extra option/link/button you could select to turn on the GridModifyBehaviour - because you sometimes just want to look, not edit :)

Cheers Shez

Attachments

web_ui.py (13.5 kB) - added by jonathanhofman on 01/08/12 17:02:21.
Added an checkbox to disable/enable the grid modify in the report overview
11274.patch (16.1 kB) - added by jonathanhofman on 02/14/12 21:48:55.
patch on gridmodify/trunk (rev11274)

Change History

12/02/08 14:09:49 changed by sincoder

  • release changed from 0.10 to 0.11.
  • priority changed from normal to highest.

I second this

12/17/09 15:24:04 changed by pr@outwit.com

Hello,

Moreover, it could be great to choose fields we want editable in the grid for each report. Very nice plugin!

Cheers,

Pierre

05/29/10 03:36:03 changed by maburns@gmail.com

bump. I'd love to have a single report that was grid-editable, but leave others normal.

08/01/10 18:42:17 changed by anonymous

  • owner changed from abbywinterscom to anonymous.
  • priority changed from highest to normal.
  • status changed from new to assigned.

08/01/10 18:46:28 changed by bjornharrtell

  • owner changed from anonymous to bjornharrtell.
  • status changed from assigned to new.

08/01/10 18:46:37 changed by bjornharrtell

  • status changed from new to assigned.

08/01/10 18:50:54 changed by bjornharrtell

  • status changed from assigned to new.

08/20/10 05:36:11 changed by anonymous

  • priority changed from normal to high.

04/28/11 16:39:19 changed by david.killick@wcn.co.uk

I was about to raise an almost identical feature request - to have a mechanism to turn the grid modify on and off - as its a very useful plugin, but less so if its 'always on'.

(follow-up: ↓ 12 ) 01/08/12 17:01:02 changed by jonathanhofman

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

01/08/12 17:02:21 changed by jonathanhofman

  • attachment web_ui.py added.

Added an checkbox to disable/enable the grid modify in the report overview

01/08/12 17:03:49 changed by jonathanhofman

  • cc set to jonathan.trackhacks@jghp.net.

(in reply to: ↑ 10 ; follow-up: ↓ 13 ) 02/02/12 08:53:00 changed by rjollos

Replying to jonathanhofman:

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

Could you please attach that as a patch, or at least report the revision that it was developed against?

02/14/12 21:48:55 changed by jonathanhofman

  • attachment 11274.patch added.

patch on gridmodify/trunk (rev11274)

(in reply to: ↑ 12 ) 02/14/12 21:55:17 changed by jonathanhofman

  • summary changed from It would be nice to be able to have gridmodify off until a link or checkbox is selected to [PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected.

Replying to rjollos:

Replying to jonathanhofman: Could you please attach that as a patch, or at least report the revision that it was developed against?

I've appended the patch. It was made agains the the lates revision 11274 on the trunk. It adds a checkbox. If you like it, would you add it to the code so it is included in future versions. As I said before, I'm fairly new to trac, so I don't know if this is the best way to do it. Comments are welcome.

02/14/12 21:57:48 changed by rjollos

  • description changed.

(follow-up: ↓ 16 ) 10/20/12 02:30:22 changed by rjollos

Further we might want to store the value in the session data.

(in reply to: ↑ 15 ) 10/20/12 12:31:03 changed by jonathanhofman

Replying to rjollos:

Further we might want to store the value in the session data.

Unfortunately there is a bug or a change in the current trac code causing the checkbox not to work anymore, because indeed the value is not saved. I have to look in to that, because it is a pretty nice feature when it is working.

When I have fixed it, I will post the new patch.

10/22/12 03:25:51 changed by rjollos

While working on #10519, it occurred to me that it would be nice to also be able to toggle notifications off with a checkbox, as the BatchModifyPlugin allows.

10/26/12 21:03:03 changed by rjollos

  • owner changed from bjornharrtell to rjollos.
  • priority changed from high to normal.

01/22/13 10:55:37 changed by falkb

  • cc changed from jonathan.trackhacks@jghp.net to jonathan.trackhacks@jghp.net, falkb.

I second this ticket a lot

01/23/13 06:24:08 changed by rjollos

  • summary changed from [PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected to [PATCH] Disable gridmodify until explicitly enabled.

Add/Change #3836 ([PATCH] Disable gridmodify until explicitly enabled)




Change Properties
Action