Modify

Opened 6 years ago

Last modified 21 months ago

#3836 new enhancement

[PATCH] Disable gridmodify until explicitly enabled

Reported by: shez@… Owned by: rjollos
Priority: normal Component: GridModifyPlugin
Severity: normal Keywords:
Cc: jonathan.trackhacks@…, falkb Trac Release: 0.11

Description (last modified by rjollos)

Hi,

GridModifyPlugin is almost very useful to us, unfortunately certain reports we use (for example those from the TimingAndEstimationPlugin) look pretty nasty when it is enabled.

This would be a non problem if reports and queries had an extra option/link/button you could select to turn on the GridModifyBehaviour - because you sometimes just want to look, not edit :)

Cheers
Shez

Attachments (2)

web_ui.py (13.5 KB) - added by jonathanhofman 3 years ago.
Added an checkbox to disable/enable the grid modify in the report overview
11274.patch (16.1 KB) - added by jonathanhofman 3 years ago.
patch on gridmodify/trunk (rev11274)

Download all attachments as: .zip

Change History (22)

comment:1 Changed 6 years ago by sincoder

  • Priority changed from normal to highest
  • Trac Release changed from 0.10 to 0.11

I second this

comment:2 Changed 5 years ago by pr@…

Hello,

Moreover, it could be great to choose fields we want editable in the grid for each report.
Very nice plugin!

Cheers,

Pierre

comment:3 Changed 4 years ago by maburns@…

bump. I'd love to have a single report that was grid-editable, but leave others normal.

comment:4 Changed 4 years ago by anonymous

  • Owner changed from abbywinterscom to anonymous
  • Priority changed from highest to normal
  • Status changed from new to assigned

comment:5 Changed 4 years ago by bjornharrtell

  • Owner changed from anonymous to bjornharrtell
  • Status changed from assigned to new

comment:6 Changed 4 years ago by bjornharrtell

  • Status changed from new to assigned

comment:7 Changed 4 years ago by bjornharrtell

  • Status changed from assigned to new

comment:8 Changed 4 years ago by anonymous

  • Priority changed from normal to high

comment:9 Changed 3 years ago by david.killick@…

I was about to raise an almost identical feature request - to have a mechanism to turn the grid modify on and off - as its a very useful plugin, but less so if its 'always on'.

comment:10 follow-up: Changed 3 years ago by jonathanhofman

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

Changed 3 years ago by jonathanhofman

Added an checkbox to disable/enable the grid modify in the report overview

comment:11 Changed 3 years ago by jonathanhofman

  • Cc jonathan.trackhacks@… added

comment:12 in reply to: ↑ 10 ; follow-up: Changed 3 years ago by rjollos

Replying to jonathanhofman:

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

Could you please attach that as a patch, or at least report the revision that it was developed against?

Changed 3 years ago by jonathanhofman

patch on gridmodify/trunk (rev11274)

comment:13 in reply to: ↑ 12 Changed 3 years ago by jonathanhofman

  • Summary changed from It would be nice to be able to have gridmodify off until a link or checkbox is selected to [PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected

Replying to rjollos:

Replying to jonathanhofman:
Could you please attach that as a patch, or at least report the revision that it was developed against?

I've appended the patch. It was made agains the the lates revision 11274 on the trunk. It adds a checkbox. If you like it, would you add it to the code so it is included in future versions. As I said before, I'm fairly new to trac, so I don't know if this is the best way to do it. Comments are welcome.

comment:14 Changed 3 years ago by rjollos

  • Description modified (diff)

comment:15 follow-up: Changed 2 years ago by rjollos

Further we might want to store the value in the session data.

comment:16 in reply to: ↑ 15 Changed 2 years ago by jonathanhofman

Replying to rjollos:

Further we might want to store the value in the session data.

Unfortunately there is a bug or a change in the current trac code causing the checkbox not to work anymore, because indeed the value is not saved. I have to look in to that, because it is a pretty nice feature when it is working.

When I have fixed it, I will post the new patch.

comment:17 Changed 2 years ago by rjollos

While working on #10519, it occurred to me that it would be nice to also be able to toggle notifications off with a checkbox, as the BatchModifyPlugin allows.

comment:18 Changed 2 years ago by rjollos

  • Owner changed from bjornharrtell to rjollos
  • Priority changed from high to normal

comment:19 Changed 21 months ago by falkb

  • Cc falkb added

I second this ticket a lot

comment:20 Changed 21 months ago by rjollos

  • Summary changed from [PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected to [PATCH] Disable gridmodify until explicitly enabled

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.