Modify

Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#3868 closed enhancement (fixed)

[Patch] Use new configuration API

Reported by: daveappendix Owned by: rjollos
Priority: normal Component: KeywordSuggestPlugin
Severity: normal Keywords:
Cc: daveappendix Trac Release: 0.11

Description (last modified by rjollos)

I modified this plugin to use the new(ish) Option, BoolOption, etc. API so that I could modify the keywords from the admin panel with IniAdminPlugin.

I based it on r4357.

It is worth noting that I slightly modified the help page url to be fully qualified URL as it was coming up as http://blah/trac/ticket/wiki/TicketKeywords.

Attachments (1)

keywordsuggest.py (4.6 KB) - added by daveappendix 6 years ago.
Modified keywordsuggest.py to use new configuration api

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by daveappendix

Modified keywordsuggest.py to use new configuration api

comment:1 Changed 6 years ago by daveappendix

  • Cc daveappendix added; anonymous removed

comment:2 Changed 6 years ago by phaidros

I tried the patched keywordsuggest.py, but the options don't show up in the IniAdminPlugin. I'm using trac 0.11.1 release.

comment:3 Changed 6 years ago by daveappendix

I'm also on Trac 0.11.1. I'm using IniAdminPlugin r3915, if that's any help.

I didn't do anything out of the ordinary to get it to work, just recompiled TracKeywordSuggest-0.2-py2.5.egg, shoved it in /path/to/trac/plugins and reloaded apache.

comment:4 Changed 6 years ago by phaidros

thanks daveappendix! with suggested version of iniadmin (r3915) it works.

comment:5 Changed 4 years ago by rjollos

  • Summary changed from Patch to use new configuration API to [Patch] Use new configuration API

comment:6 Changed 3 years ago by rjollos

  • Description modified (diff)

comment:7 Changed 3 years ago by rjollos

  • Owner changed from scratcher to rjollos

Thanks for submitting these changes. Submitting your changes as a patch is always preferred, but it will work okay this time.

comment:8 Changed 3 years ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [10431]) Fixes #3868: Use Trac's new configuration API for handling options from trac.ini. Bumped version of plugin to 0.3.

Thanks to daveappendix for the patch.

comment:9 Changed 3 years ago by rjollos

(In [10739]) Refs #3868: Removed egg that was accidentally committed in [10431].

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.