Ticket #3965 (closed defect: fixed)

Opened 5 years ago

Last modified 2 years ago

BreadCrumbsNavPlugin produces invalid xhtml (strict)

Reported by: jholg@gmx.de Assigned to: hasienda
Priority: normal Component: BreadCrumbsNavPlugin
Severity: major Keywords: xhtml valid
Cc: Trac Release: 0.11

Description

Disclaimer: I'm a newbie on these issues.

That said, Trac seems to produce nice valid xhtml 1.0 strict. breadcrumbsplugin breaks this by introducing <lh>Breadcrumbs:<lh>, with <lh/> not being allowed as a child of <ul/>

Proposed fix: Change the relevant css portion to

ul#breadcrumbs li:first-child {

color: #d1d1d1;

}

and make the "Breadcrumbs:" string appear as a simple <li/> instead of an <lh/>, but with the different color. So the effect should be the very same. This seems to work for me with Firefox 2.0.0.6 and also IE 6. Patch diff attached.

Regards, Holger

Attachments

breadcrumbsplugin.patch (1.2 kB) - added by jholg@gmx.de on 10/22/08 16:33:12.
breadcrumbsplugin patch for xhtml 1.0 validity
breadcrumbsnavplugin_valid_xhtml_patch.diff (1.2 kB) - added by jholg on 01/09/09 05:13:38.
xhtml-validity patch for breadcrumbsnavplugin

Change History

10/22/08 16:33:12 changed by jholg@gmx.de

  • attachment breadcrumbsplugin.patch added.

breadcrumbsplugin patch for xhtml 1.0 validity

01/09/09 05:13:38 changed by jholg

  • attachment breadcrumbsnavplugin_valid_xhtml_patch.diff added.

xhtml-validity patch for breadcrumbsnavplugin

(follow-up: ↓ 2 ) 01/09/09 05:23:10 changed by jholg

pls ignore my last attachment, this is just a repost of the previous one - for some reason it does not get correctly rendered in trac, but it is not empty...

(in reply to: ↑ 1 ) 11/16/10 01:17:15 changed by hasienda

  • keywords set to xhtml valid.

Replying to jholg:

pls ignore my last attachment, this is just a repost of the previous one - for some reason it does not get correctly rendered in trac, but it is not empty...

Sure, don't worry. Diff renderer is known to have problems with some diff formats, i.e. on timestamps in the header. There is still the option to download in original format, that will reveal the full content.

10/22/11 23:13:04 changed by hasienda

  • owner changed from ixokai to hasienda.
  • summary changed from breadcrumbsplugin produces invalid xhtml (strict) to BreadCrumbsNavPlugin produces invalid xhtml (strict).

just straitening for changelog ;-)

11/09/11 00:26:14 changed by hasienda

(In [10889]) BreadCrumbsNavPlugin: Make HTML markup valid XHTML, refs #3965.

Thanks to jholg for the report and contribution of better code. I took the chance to flatten the CSS code for readability.

11/09/11 01:19:20 changed by hasienda

(In [10893]) BreadCrumbsNavPlugin: Assign Trac CSS classes for proper display, refs #3965.

The '|' after label, introduced by the fix for #3965, should be suppressed. While on it, add appropriate CSS class for the last list item too.

On the same move withdraw link style to allow for custom styling i.e. from site.css instead.

11/09/11 21:01:34 changed by hasienda

  • status changed from new to closed.
  • resolution set to fixed.

(In [10896]) BreadCrumbsNavPlugin: Tag long overdue maintenance release 0.2, closes #2463, #3965, #4037, #4411, #7036 and #7231.

Fix erroneously introduced version mismatch between changelog and setup.py.

11/11/11 19:35:17 changed by hasienda

(In [10901]) BreadCrumbsNavPlugin: Fix crumbs list handling, refs #3965.

Code introduced in [10893] was not handling an empty list gracefully. Futhermore, when hiding of current resource results in an empty list, the list label should be suppressed as well.

Add/Change #3965 (BreadCrumbsNavPlugin produces invalid xhtml (strict))




Change Properties
Action