Modify

Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#3965 closed defect (fixed)

BreadCrumbsNavPlugin produces invalid xhtml (strict)

Reported by: jholg@… Owned by: hasienda
Priority: normal Component: BreadCrumbsNavPlugin
Severity: major Keywords: xhtml valid
Cc: Trac Release: 0.11

Description

Disclaimer: I'm a newbie on these issues.

That said, Trac seems to produce nice valid xhtml 1.0 strict.
breadcrumbsplugin breaks this by introducing <lh>Breadcrumbs:<lh>, with <lh/> not being
allowed as a child of <ul/>

Proposed fix: Change the relevant css portion to

ul#breadcrumbs li:first-child {

color: #d1d1d1;

}

and make the "Breadcrumbs:" string appear as a simple <li/> instead of an <lh/>, but
with the different color. So the effect should be the very same.
This seems to work for me with Firefox 2.0.0.6 and also IE 6.
Patch diff attached.

Regards,
Holger

Attachments (2)

breadcrumbsplugin.patch (1.2 KB) - added by jholg@… 6 years ago.
breadcrumbsplugin patch for xhtml 1.0 validity
breadcrumbsnavplugin_valid_xhtml_patch.diff (1.2 KB) - added by jholg 6 years ago.
xhtml-validity patch for breadcrumbsnavplugin

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by jholg@…

breadcrumbsplugin patch for xhtml 1.0 validity

Changed 6 years ago by jholg

xhtml-validity patch for breadcrumbsnavplugin

comment:1 follow-up: Changed 6 years ago by jholg

pls ignore my last attachment, this is just a repost of the previous one - for some reason it does not get correctly rendered in trac, but it is not empty...

comment:2 in reply to: ↑ 1 Changed 4 years ago by hasienda

  • Keywords xhtml valid added

Replying to jholg:

pls ignore my last attachment, this is just a repost of the previous one - for some reason it does not get correctly rendered in trac, but it is not empty...

Sure, don't worry. Diff renderer is known to have problems with some diff formats, i.e. on timestamps in the header. There is still the option to download in original format, that will reveal the full content.

comment:3 Changed 3 years ago by hasienda

  • Owner changed from ixokai to hasienda
  • Summary changed from breadcrumbsplugin produces invalid xhtml (strict) to BreadCrumbsNavPlugin produces invalid xhtml (strict)

just straitening for changelog ;-)

comment:4 Changed 3 years ago by hasienda

(In [10889]) BreadCrumbsNavPlugin: Make HTML markup valid XHTML, refs #3965.

Thanks to jholg for the report and contribution of better code.
I took the chance to flatten the CSS code for readability.

comment:5 Changed 3 years ago by hasienda

(In [10893]) BreadCrumbsNavPlugin: Assign Trac CSS classes for proper display, refs #3965.

The '|' after label, introduced by the fix for #3965, should be suppressed.
While on it, add appropriate CSS class for the last list item too.

On the same move withdraw link style to allow for custom styling i.e. from
site.css instead.

comment:6 Changed 3 years ago by hasienda

  • Resolution set to fixed
  • Status changed from new to closed

(In [10896]) BreadCrumbsNavPlugin: Tag long overdue maintenance release 0.2, closes #2463, #3965, #4037, #4411, #7036 and #7231.

Fix erroneously introduced version mismatch between changelog and setup.py.

comment:7 Changed 3 years ago by hasienda

(In [10901]) BreadCrumbsNavPlugin: Fix crumbs list handling, refs #3965.

Code introduced in [10893] was not handling an empty list gracefully.
Futhermore, when hiding of current resource results in an empty list, the
list label should be suppressed as well.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hasienda. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.