Modify

Opened 6 years ago

Closed 4 years ago

#4002 closed enhancement (fixed)

[Patch] Never Notify Updater and Always Notify Component Owner flags

Reported by: sromanow@… Owned by: doki_pen
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: nic4@…, mkc Trac Release: 0.11

Description

Two things:

  • Please add functionality of Never Notify Updater. Similar issue as #3778.
  • Please add Always Update Component Owner flag so I can disable emails to this recipient class.

Attachments (1)

legacy-never-notify-updater.patch (3.8 KB) - added by mkc 5 years ago.
Implementation of "nevernotifyupdater" for announcer legacy subscriber

Download all attachments as: .zip

Change History (17)

comment:1 Changed 6 years ago by slestak

  • Owner changed from doki_pen to slestak

comment:2 Changed 6 years ago by slestak

  • Status changed from new to assigned

comment:3 follow-up: Changed 6 years ago by slestak

I like the thoughts on this ticket.

always* sure does get squishy when pressed.

I am concerned about if someone sets always_notify_updater and never_notify_updater. Since I am proposing carrying both options, it will be possible to set both on.

comment:4 Changed 6 years ago by anonymous

  • Cc nic4@… added

comment:5 in reply to: ↑ 3 Changed 5 years ago by rjollos

Replying to slestak:

I like the thoughts on this ticket.


I completely agree with that. From the testing I have done, it seems that the Never Notify updater plugin works with the Announcer plugin, but the never notify settings are over-ridden when Notify me of changes to tickets that I own and Notify me of changes to tickets that I reported are selected.

So, if Notify me of changes to tickets that I own and Notify me of changes to tickets that I reported are selected, and you are not the owner or the reporter, then you won't get an email notification for your own update. But if you are the owner or reporter, you will receive an email notifying you of your own update.

comment:6 Changed 5 years ago by rjollos

  • Cc ryano@… added

comment:7 Changed 5 years ago by slestak

  • Owner slestak deleted
  • Status changed from assigned to new

Changed 5 years ago by mkc

Implementation of "nevernotifyupdater" for announcer legacy subscriber

comment:8 Changed 5 years ago by mkc

  • Cc mkc added

Attached file adds user-configurable option to prevent emails originating from a user's own updates if "never_notify_updater" is enabled in the [announcer] section of trac.ini.

comment:9 Changed 5 years ago by rjollos

  • Summary changed from Never Notify Updater and Always Notify Component Owner flags to [Patch] Never Notify Updater and Always Notify Component Owner flags

Would it be possible to have this incorporated into the trunk?

comment:10 Changed 5 years ago by rjollos

  • Owner set to doki_pen

Assigning to maintainer in case this one was missed.

comment:11 Changed 5 years ago by doki_pen

  • Status changed from new to assigned

comment:12 follow-up: Changed 5 years ago by doki_pen

I've been thinking about this a lot. The trouble is that the rules can be complicated. One of my goals with the announcer plugin is to give the user more control over what notifications they receive. It is hard to make these complex rules accessible to the user, but here is where my mind is at now. The UI would look something like this and would be in the users preferences:

+ notify me of changes to tickets that I own.
+ notify me of changes to tickets that I created.
+ notify me of changes to tickets that I modify.
etc..

The options would be setup to some default that makes sense for the site and the users would be able to do three things:

  • disable/enable a rule
  • select always/never for a rule
  • change the order of the rules

The rules would be applied in order, so the ones lower in the list would always take precedence. The + would be some drag-n-drop thing. We could have something more simple for sans-javascript.

Does this make sense and seem like something people would want? Any better ideas?

comment:13 in reply to: ↑ 12 Changed 5 years ago by rjollos

Replying to doki_pen:

Seems like that would work well, provided you have the following rule.

+ notify me of my own changes to tickets.

Would there be a way by which the administrator could specify a default set of rules?

comment:14 Changed 5 years ago by rjollos

  • Cc ryano@… removed

comment:15 Changed 5 years ago by rjollos

One issue I have noticed with the current patch is that if I have "subscribed" to a ticket by adding myself to the CC list, the "Don't notify me of my own changes to tickets" is not respected.

comment:16 Changed 4 years ago by doki_pen

  • Resolution set to fixed
  • Status changed from assigned to closed

I tested on trunk and it works. If you add your username to the CC field, then things work as expected. There is no reverse lookup for email addresses, so you'll have to think of email addresses in CC fields as anonymous users with no settings (for now). Make a new ticket for reverse address lookup and I'll think about it some more, but it's unlikely to get done soon.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from doki_pen. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.