Modify

Opened 6 years ago

Closed 6 years ago

#4015 closed defect (fixed)

ValueError: close_fds is not supported on Windows platforms

Reported by: jj026799 Owned by: lei
Priority: normal Component: PageToDocIntegration
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

This isn't really a python bug, but it effects this plug-in on Windows. close_fds is not supported for Windows in C:\Python25\Lib\subprocess.py

Here's the information: http://www.python.org/doc/2.5.2/lib/node528.html

Everything installs correctly but when clicking on the Download in other formats > MS Word link on the bottom of the wiki the following happens:

How to Reproduce

While doing a GET operation on /wiki/WikiStart, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{'format': u'zip', 'page': u'WikiStart'}

User Agent was: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3

System Information

Trac 0.11.1
Python 2.5.2 (r252:60911, Mar 27 2008, 17:57:18) [MSC v.1310 32 bit (Intel)]
setuptools 0.6c7
SQLite 3.5.2
pysqlite 2.4.0
Genshi 0.5
mod_python 3.3.1
Subversion 1.5.3 (r33570)
jQuery: 1.2.6

Python Traceback

Traceback (most recent call last):
  File "C:\Python25\Lib\site-packages\trac\web\main.py", line 423, in _dispatch_request
    dispatcher.dispatch(req)
  File "C:\Python25\Lib\site-packages\trac\web\main.py", line 197, in dispatch
    resp = chosen_handler.process_request(req)
  File "C:\Python25\Lib\site-packages\trac\wiki\web_ui.py", line 161, in process_request
    format, versioned_page.name)
  File "C:\Python25\Lib\site-packages\trac\mimeview\api.py", line 834, in send_converted
    content, selector)
  File "C:\Python25\Lib\site-packages\trac\mimeview\api.py", line 560, in convert_content
    output = converter.convert_content(req, mimetype, content, ck)
  File "build\bdist.win32\egg\pagetodoc\pagetodoc.py", line 96, in convert_content
    self.execute_external_program(cmd)
  File "build\bdist.win32\egg\pagetodoc\pagetodoc.py", line 140, in execute_external_program
    retval = subprocess.call(command, shell=True, stderr=errptr, stdout=outptr, close_fds=True)
  File "C:\Python25\Lib\subprocess.py", line 444, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\Python25\Lib\subprocess.py", line 552, in __init__
    raise ValueError("close_fds is not supported on Windows "
ValueError: close_fds is not supported on Windows platforms

Attachments (0)

Change History (2)

comment:1 Changed 6 years ago by anonymous

This is also broken in Python24.

comment:2 Changed 6 years ago by markm

  • Resolution set to fixed
  • Status changed from new to closed

This should be fixed now in [5399]

Add Comment

Modify Ticket

Action
as closed The owner will remain lei.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.