Default configuration for "paths" configuration seems unintended
|Reported by:||matthijs||Owned by:||hasienda|
The default value for the "paths" configuration is "/wiki*,/ticket*,/milestone". According to the code, each of the elements in this list is interpreted as a regex and passed to re.match.
From looking at this, it looks like the * should match anything, so /wiki* should match anything starting with wiki. However, this is a regex, so it should be /wiki.* Now, the * only serves to make the i preceding it optional: /wiki* matches /wik, /wikfoo, /wikiiiiii, etc.
Furthermore, the re.match function already handles the "starts with" part, so just "/wiki" should be enough.
Lastly, I would expect the / after wiki to be included. Currently, /wikifoo would also match, while you would want to limit to /wiki/foo.
I propose changing the default value of "paths" to "/wiki/,/ticket/,/milestone/". Would that make sense?
Change History (4)
comment:2 Changed 3 years ago by hasienda
- Keywords regexp added
- Owner changed from ixokai to hasienda
- Status changed from new to assigned