Ticket #4037 (closed defect: fixed)

Opened 5 years ago

Last modified 2 years ago

Default configuration for "paths" configuration seems unintended

Reported by: matthijs Assigned to: hasienda
Priority: normal Component: BreadCrumbsNavPlugin
Severity: normal Keywords: regexp
Cc: Trac Release: 0.11

Description

The default value for the "paths" configuration is "/wiki*,/ticket*,/milestone". According to the code, each of the elements in this list is interpreted as a regex and passed to re.match.

From looking at this, it looks like the * should match anything, so /wiki* should match anything starting with wiki. However, this is a regex, so it should be /wiki.* Now, the * only serves to make the i preceding it optional: /wiki* matches /wik, /wikfoo, /wikiiiiii, etc.

Furthermore, the re.match function already handles the "starts with" part, so just "/wiki" should be enough.

Lastly, I would expect the / after wiki to be included. Currently, /wikifoo would also match, while you would want to limit to /wiki/foo.

I propose changing the default value of "paths" to "/wiki/,/ticket/,/milestone/". Would that make sense?

Attachments

Change History

02/09/09 01:01:46 changed by peterA

I agree. The proposal works fine for me.

11/07/11 22:31:02 changed by hasienda

  • status changed from new to assigned.
  • keywords set to regexp.
  • owner changed from ixokai to hasienda.

This has been merged with the source here locally.

Will take care, as soon as I get access to the repository.

11/09/11 00:31:49 changed by hasienda

(In [10891]) BreadCrumbsNavPlugin: Improve default configuration for 'supported_paths' ListOption, refs #4037.

Thanks to matthijs for a very detailed, educating report.

11/09/11 21:01:48 changed by hasienda

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [10896]) BreadCrumbsNavPlugin: Tag long overdue maintenance release 0.2, closes #2463, #3965, #4037, #4411, #7036 and #7231.

Fix erroneously introduced version mismatch between changelog and setup.py.


Add/Change #4037 (Default configuration for "paths" configuration seems unintended)




Change Properties
Action