Ticket #411 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Content-Type test fails to match headers with additional information

Reported by: careo@fastmail.fm Assigned to: athomas
Priority: normal Component: XmlRpcPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

For example, Ruby's xmlrpc lib helpfully sets the content-type to "text/xml; charset=utf-8".

Attachments

content-type-sniffing.patch (0.5 kB) - added by careo on 06/06/06 18:14:32.
content-type_detect.patch (0.5 kB) - added by mpalmer@hezmatt.org on 07/20/06 21:11:28.
Better fix for the problem
content-type_detect.2.patch (0.7 kB) - added by mpalmer@hezmatt.org on 07/20/06 21:12:36.
Better fix for the problem (proper patch)

Change History

06/06/06 18:14:32 changed by careo

  • attachment content-type-sniffing.patch added.

06/06/06 18:59:29 changed by careo

The patch attached previously, while a fix for the content-type sniffing, will break the web view because req.get_header('Content-Type') will return None.

06/09/06 16:00:51 changed by careo

The dirty little hack I applied to make it work with ruby (not even worth making a patch) is to change the line in question to if req.get_header('Content-Type') != 'text/xml' or req.get_header('Content-Type') != 'text/xml; charset=utf-8:'

07/20/06 21:11:28 changed by mpalmer@hezmatt.org

  • attachment content-type_detect.patch added.

Better fix for the problem

07/20/06 21:12:36 changed by mpalmer@hezmatt.org

  • attachment content-type_detect.2.patch added.

Better fix for the problem (proper patch)

07/20/06 21:15:07 changed by mpalmer@hezmatt.org

A fix that, so far as I can tell, works for both the HTML side and the XML-RPC side. This fix is quite critical for me, as without my Ruby client code Just Doesn't Work.

07/29/06 22:12:50 changed by athomas

  • status changed from new to closed.
  • resolution set to fixed.

(In [1070]) Fixes #550, #483, #530 and #411 (hopefully).

Add/Change #411 (Content-Type test fails to match headers with additional information)




Change Properties
Action