Modify

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#4113 closed defect (fixed)

Error with SSL/Authentication

Reported by: atle@… Owned by: roadrunner
Priority: normal Component: HudsonTracPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

When Hudson is running on https and with HTTP Authentication...

The parsing of details will fail because of the request for the /api/json details will just contain the 401 error, not a valid json object.

Even when the RSS url is on basic http, it uses the links in the rss feed to get the details, and they contain in my case the https links

Attachments (1)

HudsonTracPlugin.py (4.6 KB) - added by roadrunner 6 years ago.
Patched plugin to support authentication

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by roadrunner

  • Status changed from new to assigned

For the feed you should be able to include the username and password in the feed_url (i.e. https://user:pass@.../). But yes, for the details this won't work.

Ok, I'm attaching a patched version the plugin which adds username and password options and passes those to all urls (the username/password need not be embedded in the feed url). Please try it out and let me know (I've only tested to the point that it doesn't seem to break anything).

Changed 6 years ago by roadrunner

Patched plugin to support authentication

comment:2 Changed 6 years ago by anonymous

Can anyone update if this issue has been fixed?

comment:3 Changed 6 years ago by roadrunner

If someone could confirm that the attached version actually works on a password-protected hudson instance I will check in the fix and close the ticket.

comment:4 Changed 6 years ago by roadrunner

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5698]) Added support for configuring hudson authentication info. This closes #4113.

comment:5 Changed 5 years ago by roadrunner

(In [6100]) Fixed authentication handling. There were two issues:

  1. need to register the auth info for all paths not just the feed, because the descriptions will have different paths
  2. feedparser's authentication handling is broken (there's an over two year old bug report on it at http://code.google.com/p/feedparser/issues/detail?id=40 but the fix there is not correct). So we just open the url ourselves which avoids feedparser's handler and hence the problem.

This really fixes #4113 and hopefully addresses #5430.

Add Comment

Modify Ticket

Action
as closed The owner will remain roadrunner.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.