Modify

Opened 6 years ago

#4266 new defect

setting base_url corrupts ticket URLs in client projects - use tracforge.uri_root instead?

Reported by: jholg Owned by: coderanger
Priority: normal Component: TracForgePlugin
Severity: normal Keywords: tracforge notification ticket-URL
Cc: Trac Release: 0.11

Description

TracForgePlugin utilizes trac.base_url option to construct the login/logout links. This breaks email notification ticket URLs for client projects

I suggest using tracforge's own uri_root option instead; this seems to work for my setup, I'm however a bit unsure of what uri_root is supposed to mean in the first place. The doc string says 'The smallest common URI for the whole TracForge setup'.

In a multi-project setup with master project "master" and client projects "client1" and "client2", would that be /master (must be relative)?

Anyhow, for my usecase this configuration does seem to work fine - appropriate patch attached.

Btw TracForgePlugin is great - it's what makes Trac usable in my environment in the first place.

Cheers, Holger

Attachments (1)

auth.py.diff (1.7 KB) - added by jholg 6 years ago.
patch tracforge/linker/auth.py to use tracforge.uri_root instead of master trac.base_url

Download all attachments as: .zip

Change History (1)

Changed 6 years ago by jholg

patch tracforge/linker/auth.py to use tracforge.uri_root instead of master trac.base_url

Add Comment

Modify Ticket

Action
as new The owner will remain coderanger.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.