Modify

Opened 6 years ago

Closed 4 years ago

#4454 closed enhancement (wontfix)

Change button should match style of Reply button and be positioned below the reply button

Reported by: jevans Owned by: rjollos
Priority: normal Component: TicketChangePlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Maintaining the same style would help with professional feel.

(Although keeping the label a different color might not be bad to minimize accidental hits.)

Attachments (1)

TicketChangePlugin.png (4.5 KB) - added by rjollos 5 years ago.
Screen capture

Download all attachments as: .zip

Change History (13)

comment:1 Changed 6 years ago by kontakt@…

I'm using some custom CSS styles to improve my Trac experience anyways, so I've just added these lines to my custom style.css:

div.inlinebuttons a {
  border: 1px dotted #CCC;
  color: #222;
  font-size: 70%;
  margin: 0 0.1em;
  padding: 0.1em;
}

There's a 1px height difference compared to the Reply-Button that I've not yet managed to extinguish, but that's just my lazyness.

comment:2 Changed 5 years ago by rjollos

  • Cc rjollos added; anonymous removed

comment:3 Changed 5 years ago by rjollos

It might be useful to look at how this was done for the CloneTicketPlugin.

comment:4 Changed 5 years ago by rjollos

  • Cc anonymous added; rjollos removed
  • Summary changed from Have Change buttons match style of Reply buttons to Change button should match style of Reply button

Screen capture with TicketChangePlugin, TicketDeletePlugin, and GamedevTheme installed.

Screen capture

Changed 5 years ago by rjollos

Screen capture

comment:5 Changed 5 years ago by rjollos

See also #5481.

comment:6 Changed 5 years ago by rjollos

  • Resolution set to duplicate
  • Status changed from new to closed

Closing as a duplicate since #5481 requests this feature.

comment:7 Changed 5 years ago by jevans

Well normally you might close the higher number ticket as the duplicate :-)

In this particular case they seem unique as this ticket is concerned with appearance while #5481 is primarily concerned with placement. Of course that doesn't mean that the same fix couldn't perhaps fix both.

Personally I prefer the layout of your attachment to this ticket over the layout shown in #5481, but perhaps that's just the difference in having a code block in the comment.

comment:8 Changed 5 years ago by rjollos

  • Resolution duplicate deleted
  • Status changed from closed to reopened
  • Summary changed from Change button should match style of Reply button to Change button should match style of Reply button and be positioned below the reply button

That makes sense. Seems like they could both be handled in one fix, so I'll append the other fix to summary for this ticket.

comment:9 Changed 5 years ago by rjollos

Also, hoping to get this fixed soon, see #6628.

comment:10 Changed 4 years ago by rjollos

  • Owner changed from SergeiLuchko to rjollos
  • Status changed from reopened to new

comment:11 Changed 4 years ago by rjollos

  • Status changed from new to assigned

comment:12 Changed 4 years ago by rjollos

  • Resolution set to wontfix
  • Status changed from assigned to closed

Closing as wontfix since the functionality has been integrated into the Trac core. See the news on the plugin's main page.

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.