Modify

Opened 6 years ago

Closed 4 years ago

#4498 closed defect (fixed)

tags not handled correctly

Reported by: izzy Owned by: Blackhex
Priority: normal Component: ScreenshotsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

When adding tags to a screenshot, the plugin not only inserts the specified tags, but also adds author, components, versions and name as tags - which is not what is usually done (neither tickets nor wiki pages show the same behaviour). Moreover, if one then decides to remove the tags again (by emptying the corresponding field), only the contents of that field get removed. To remove the other tags, one needs to drop the screenshot completely.

I created a patch to change that behaviour to be more "trac-like" (i.e. it will only add the specified tags, and not the other elements). You can simply apply this patch if you agree to handle tags like the other components do. Otherwise, you should add least make this optional (and turned off by default).

Attachments (1)

tags-only.diff (641 bytes) - added by izzy 6 years ago.
when adding tags, only add the tags to the tags table (and not author, components, etc. as well)

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by izzy

when adding tags, only add the tags to the tags table (and not author, components, etc. as well)

comment:1 Changed 6 years ago by Blackhex

  • Status changed from new to assigned

That is matter of taste. I can add options to disable tagging of name, author, component and version but the claim that tickets don't do this is wrong. Opened tickets generate author, component and version tags. Just see Tags on this server. That's why I did it how it is.

comment:2 Changed 6 years ago by izzy

That is what I compared: I tagged wiki pages, some tickets, and some screenshots. Then I went to the /tags URL. From the wiki and ticket tags, only the tags have been taken - while the screenshots additionally displayed author etc. as tags.

But however: Having the possibility to switch that off (and only "tag the tags") would be fine. As it is now, you have the problem that you cannot even "untag" name and author without deleting the screenshot.

Generally, the idea to have tags on the version and component is not that bad - it's simply not always suitable. Just why to tag the name I cannot understand. Having these things optionally, however, cannot hurt anyone ;)

comment:3 Changed 4 years ago by Blackhex

  • Resolution set to fixed
  • Status changed from assigned to closed

r7486 adds additional_tags config option.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Blackhex. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.