Ticket #4547 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

[Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses

Reported by: geoff Assigned to: retracile
Priority: normal Component: AdvancedTicketWorkflowPlugin
Severity: normal Keywords:
Cc: hju@jochenkuhl.de Trac Release: 0.11

Description

Instances of ConfigurableTicketWorkflow? are created directly in the plugin rather than searching TicketSystem?.action_controllers for an appropriate instance. This can cause actions to be visible when they should not be, such as when TypedTicketWorkflowPlugin is being used. This patch searches for an instance of ConfigurableTicketWorkflow? to use, creating a default one if necessary.

Attachments

advancedticketworkflowplugin-4547.patch (2.0 kB) - added by geoff on 01/29/09 19:05:20.
patch against r5169

Change History

01/29/09 19:05:20 changed by geoff

  • attachment advancedticketworkflowplugin-4547.patch added.

patch against r5169

02/11/09 21:53:00 changed by anonymous

  • cc set to hju@jochenkuhl.de.

10/23/09 23:46:37 changed by hju@jochenkuhl.de

The patch works fine.

But it is also necessary to replace 

actions = ConfigurableTicketWorkflow(self.env).actions

with 

actions = self.get_configurable_workflow().actions

(follow-up: ↓ 4 ) 11/04/09 04:59:01 changed by anonymous

Does anyone have more details on this?

I have tried to implement these changes a few times yet still cant get it to work.

(in reply to: ↑ 3 ) 11/04/09 05:09:45 changed by anonymous

Replying to anonymous:

Does anyone have more details on this? I have tried to implement these changes a few times yet still cant get it to work.

Ignore this comment.... I'm an idiot.... big difference between ticketype and ticketType

11/05/09 03:01:44 changed by rjollos

  • owner changed from retracile to rjollos.
  • status changed from new to assigned.
  • summary changed from AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses to [Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses.

11/05/09 03:03:02 changed by rjollos

  • owner changed from rjollos to retracile.
  • status changed from assigned to new.

03/16/11 15:09:24 changed by retracile

  • status changed from new to closed.
  • resolution set to fixed.

I reworked the patch somewhat and committed it in [9960]. Thanks!

Add/Change #4547 ([Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses)




Change Properties
Action