Modify

Opened 6 years ago

Closed 3 years ago

#4547 closed defect (fixed)

[Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses

Reported by: geoff Owned by: retracile
Priority: normal Component: AdvancedTicketWorkflowPlugin
Severity: normal Keywords:
Cc: hju@… Trac Release: 0.11

Description

Instances of ConfigurableTicketWorkflow are created directly in the plugin rather than searching TicketSystem.action_controllers for an appropriate instance. This can cause actions to be visible when they should not be, such as when TypedTicketWorkflowPlugin is being used. This patch searches for an instance of ConfigurableTicketWorkflow to use, creating a default one if necessary.

Attachments (1)

advancedticketworkflowplugin-4547.patch (2.0 KB) - added by geoff 6 years ago.
patch against r5169

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by geoff

patch against r5169

comment:1 Changed 6 years ago by anonymous

  • Cc hju@… added

comment:2 Changed 5 years ago by hju@…

The patch works fine.

But it is also necessary to replace

actions = ConfigurableTicketWorkflow(self.env).actions

with

actions = self.get_configurable_workflow().actions

comment:3 follow-up: Changed 5 years ago by anonymous

Does anyone have more details on this?

I have tried to implement these changes a few times yet still cant get it to work.

comment:4 in reply to: ↑ 3 Changed 5 years ago by anonymous

Replying to anonymous:

Does anyone have more details on this?

I have tried to implement these changes a few times yet still cant get it to work.

Ignore this comment.... I'm an idiot.... big difference between ticketype and ticketType

comment:5 Changed 5 years ago by rjollos

  • Owner changed from retracile to rjollos
  • Status changed from new to assigned
  • Summary changed from AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses to [Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses

comment:6 Changed 5 years ago by rjollos

  • Owner changed from rjollos to retracile
  • Status changed from assigned to new

comment:7 Changed 3 years ago by retracile

  • Resolution set to fixed
  • Status changed from new to closed

I reworked the patch somewhat and committed it in [9960]. Thanks!

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.