Modify

Opened 6 years ago

Closed 8 months ago

Last modified 8 months ago

#4548 closed defect (fixed)

[Patch] TypedTicketWorkflow should also override get_actions_by_operation_for_req

Reported by: geoff Owned by: rjollos
Priority: normal Component: TypedTicketWorkflowPlugin
Severity: normal Keywords:
Cc: rjollos Trac Release: 0.11

Description

Other workflow plugins use ConfigurableTicketWorkflow.get_actions_by_operation_for_req to determine if their plugin's action can be used. Since TypedTicketWorkflow doesn't override this method it cannot be used to remove these actions from display. This patch implements this method.

Attachments (1)

typedticketworkflowplugin-4548.patch (763 bytes) - added by geoff 6 years ago.
patch against r5169

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by geoff

patch against r5169

comment:2 follow-up: Changed 6 years ago by kivsiak

  • Status changed from new to assigned

Thanks for your patch. I'll apply it to next version

comment:3 Changed 5 years ago by rjollos

  • Cc rjollos added

comment:4 follow-up: Changed 5 years ago by anonymous

Does this work? Been trying this and the "fix" on #4547 and cant get it to work properly...

Last edited 8 months ago by rjollos (previous) (diff)

comment:5 in reply to: ↑ 4 Changed 5 years ago by anonymous

Replying to anonymous:

Does this work? Been trying this and the "fix" on #4547 and cant get it to work properly...

Ignore this comment.... I'm an idiot.... big difference between ticketype and ticketType.

Last edited 8 months ago by rjollos (previous) (diff)

comment:6 in reply to: ↑ 2 Changed 5 years ago by anonymous

Replying to kivsiak:

Thanks for your patch. I'll apply it to next version

For when is the next version planned?

comment:7 Changed 5 years ago by rjollos

  • Summary changed from TypedTicketWorkflow should also override get_actions_by_operation_for_req to [Patch] TypedTicketWorkflow should also override get_actions_by_operation_for_req

comment:8 Changed 8 months ago by glinders

Hi, the patch works for me in Trac 1.0 using TypedTicketWorkflow_plugin-0.1dev_r4791-py2.7.egg.

Last edited 8 months ago by rjollos (previous) (diff)

comment:9 Changed 8 months ago by rjollos

  • Owner changed from kivsiak to rjollos
  • Status changed from assigned to accepted

Thanks, I'll apply the patch then.

comment:10 Changed 8 months ago by rjollos

  • Resolution set to fixed
  • Status changed from accepted to closed

In 13574:

0.2dev: Override get_actions_by_operation_for_req . Fixes #4548.

Patch by geoff.

comment:11 Changed 8 months ago by rjollos

Please report back if the latest version of typedticketworkflowplugin/trunk is working well for you, then I can remove the dev from version 0.2dev. Thanks!

comment:12 Changed 8 months ago by glinders

It works for me with Trac 1.0.

comment:13 Changed 8 months ago by rjollos

In 13576:

0.2: Bump version from 0.2dev to 0.2. Refs #4548.

Thanks to glinders for testing the latest.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.