Modify

Opened 6 years ago

Closed 6 years ago

#4686 closed defect (invalid)

Reports ignore UNBILLABLE tickets

Reported by: roterl@… Owned by: bobbysmith007
Priority: normal Component: TimingAndEstimationPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Created tickets that doesn't mark as billable aren't shown in the reports.

eg. Clicking the "Ticket Hours" it only display the tickets that marked as billable.
The "Ticket Hours" link is: .../report/12?BILLABLE=1&UNBILLABLE=1&ASSIGNED=assigned&ACCEPTED=accepted&CLOSED=closed&NEW=new&REOPENED=reopened&STARTDATE=0&ENDDATE=2000000000
It seems that UNBILLABLE should be displayed.

To fix it I changed the queries from

AND billable.value in ($BILLABLE, $UNBILLABLE)

into

AND billable.value in (CASE WHEN $BILLABLE = '1' THEN '1' else END, CASE WHEN $UNBILLABLE = '1' THEN '0' else END)

Attachments (0)

Change History (3)

comment:1 Changed 6 years ago by bobbysmith007

Are you sure you checked both the billable and unbillable checkboxes on the page that lists the reports? It has been working for me for quite a while, so it is a bit odd that you are having issues. Typically, when you have billable checked and unbillable checked it results in /report/12?BILLABLE=1&UNBILLABLE=0... and when you have billable checked and unbillable unchecked results in a link to /report/12?BILLABLE=1&UNBILLABLE=1....

If you are sure you are actually having issues, are you receiving any javascript errors? What browser are you using? Thanks for the info.

HTH,
Russ

comment:2 Changed 6 years ago by anonymous

I find out that the billable and the unbillable have inversed check status (when check one set to 1 and the other set to 0)
This lead to me to think that the 0 has wrong results.
Sorry for that.

Any way, I think it better to keep convenience of set is "1" and unset is "0".

thanks
Rotem.

comment:3 Changed 6 years ago by bobbysmith007

  • Resolution set to invalid
  • Status changed from new to closed

You are certainly welcome to continue using your changes, however, I do not think that I will include them into the main version of the plugin, as there is not really a benefit to implementing them.

Thanks for the feedback,
Russ

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.