Modify

Opened 6 years ago

Closed 6 years ago

#4746 closed defect (fixed)

change render_macro to expand_macro

Reported by: jay.w.xie@… Owned by: pkropf
Priority: normal Component: GraphvizPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

It seems render_macro has been changed to expand_macro but line 188 is still using it.

I'm using the 0.11 branch of GraphvizPlugin.

The log:

2009-03-05 11:32:28,072 Trac[api] WARNING: HTML preview using <graphviz.graphviz.Graphviz object at 0x2a9dd0a690> failed ('Graphviz' object has no attribute 'render_macro')
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/Trac-0.12dev_r7512-py2.5.egg/trac/mimeview/api.py", line 634, in render
    rendered_content, filename, url)
  File "build/bdist.linux-x86_64/egg/graphviz/graphviz.py", line 188, in render
    return self.render_macro(context, name, text)
AttributeError: 'Graphviz' object has no attribute 'render_macro'

Attachments (0)

Change History (1)

comment:1 Changed 6 years ago by cboos

  • Resolution set to fixed
  • Status changed from new to closed

(In [5900]) GraphvizPlugin: it was not possible to use the plugin as a renderer.

We were still calling render_macro, now replaced by expand_macro. Closes #4746.

This makes it possible to visualize dot files store in the repository with the svn:mime-type set to application/graphviz and to visualize attached dot files (when a suitable suffix is used, e.g. .graphviz).

Add Comment

Modify Ticket

Action
as closed The owner will remain pkropf.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.