Modify

Opened 6 years ago

Closed 6 years ago

#4821 closed defect (fixed)

[PATCH]: Fix tags when architecture, platform or type is not available.

Reported by: JamesMills Owned by: Blackhex
Priority: normal Component: DownloadsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Hi,

If architecture, platform or type are not available this plugin fails with a fake web traceback and a traceback in the logs.

I've attached a patch for this against r5383

--JamesMills

Attachments (0)

Change History (2)

comment:1 Changed 6 years ago by JamesMills

Patch:

  • downloadsplugin/0.11/tracdownloads/tags.py

    diff -r 4bb4134f14e6 downloadsplugin/0.11/tracdownloads/tags.py
    a b  
    121121        platform = api.get_platform(context, download['platform'])
    122122        type = api.get_type(context, download['type'])
    123123        self.log.debug(architecture)
    124         download['architecture'] = architecture['name']
    125         download['platform'] = platform['name']
    126         download['type'] = type['name']
     124        if architecture is not None:
     125            download['architecture'] = architecture['name']
     126        if platform is not None:
     127            download['platform'] = platform['name']
     128        if type is not None:
     129            download['type'] = type['name']

comment:2 Changed 6 years ago by Blackhex

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with r5598.

Add Comment

Modify Ticket

Action
as closed The owner will remain Blackhex.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.