Modify

Opened 6 years ago

Closed 3 years ago

#4843 closed defect (fixed)

post_process_request does not correctly pass content type

Reported by: onecreativenerd Owned by: rjollos
Priority: normal Component: AccountLdapPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.11

Description

AccountLdapPlugin blocks other plugins from changing the content type of their response. This was a problem for me and kept RevtreePlugin from rendering its SVG.

Here's a patch that fixes it:

  • accountldap/accountldap.py

     
    5353
    5454    def post_process_request(self, req, template, data, content_type):
    5555        if not req.remote_user or req.session.has_key('email'):
    56             return template, data, None
     56            return template, data, content_type
    5757        uid = req.remote_user.lower()
    5858        name, email = self._getUserAttributes(uid)
    5959        req.session['name'] = name
    6060        req.session['email'] = email
    61         return template, data, None
     61        return template, data, content_type
    6262    #
    6363    #----------------------------------------- INavigationContributor interface
    6464    #

This issue was a blocker for our new install.

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by anonymous

Thanks for posting this. This also caused problems with the datefield plugin on my install

comment:2 Changed 3 years ago by rjollos

  • Owner changed from clp to rjollos
  • Status changed from new to assigned

comment:3 Changed 3 years ago by rjollos

I'll see about getting this committed to the repository, to avoid more reports like #9611 (closed as duplicate).

comment:4 Changed 3 years ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

This patch was applied to the 0.12 branch in [5428]. The 0.11 branch has a README that says to use the 0.12 branch.

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.