Modify

Opened 6 years ago

Closed 6 years ago

#4861 closed defect (fixed)

t&e breaks core unit test

Reported by: mixedpuppy Owned by: bobbysmith007
Priority: normal Component: TimingAndEstimationPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Running trac unit tests with t&e installed breaks one unit test. The issue is the monkey patching of ReportModule._send_csv

====================================================================== ERROR: test_csv_escape (trac.ticket.tests.report.ReportTestCase)


Traceback (most recent call last):

File "/Users/shanec/svn/workspace/trunk/build/vendor/trac/trac/ticket/tests/report.py", line 55, in test_csv_escape

self.report_module._send_csv(req, cols, rows)

File "/Users/shanec/svn/workspace/trunk/build/plugins/timingandestimationplugin/timingandestimationplugin/reports_filter.py", line 116, in _send_csv

id = report_id_from_filename(filename)

File "/Users/shanec/svn/workspace/trunk/build/plugins/timingandestimationplugin/timingandestimationplugin/reports_filter.py", line 103, in report_id_from_filename

m = billing_report_fname_regex.match(text)

TypeError: expected string or buffer


Attachments (0)

Change History (1)

comment:1 Changed 6 years ago by bobbysmith007

  • Resolution set to fixed
  • Status changed from new to closed

(In [5494]) closes #4861 patched that so that it passes the unit tests. Thanks for the bug report.

Add Comment

Modify Ticket

Action
as closed The owner will remain bobbysmith007.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.