Modify

Opened 9 years ago

Closed 8 years ago

#53 closed defect (wontfix)

AdminConsoleProvider patch error

Reported by: leiss Owned by: athomas
Priority: normal Component: AdminConsoleProviderPatch
Severity: normal Keywords:
Cc: Trac Release:

Description

I wanted to install the DiscussionPlugin, but I can't apply the AdminConsoleProviderPatch to 0.9b1:

tups:~/trac-0.9b1/trac# patch -p1 < admin-provider-refactor.diff
patching file ticket/api.py
Hunk #1 succeeded at 21 (offset -5 lines).
Hunk #2 succeeded at 196 (offset -4 lines).
patching file Milestone.py
Hunk #1 succeeded at 25 with fuzz 2 (offset -5 lines).
Hunk #2 succeeded at 468 (offset 3 lines).
patching file scripts/admin.py
Hunk #1 FAILED at 33.
Hunk #2 succeeded at 47 (offset -4 lines).
Hunk #3 succeeded at 91 (offset -5 lines).
Hunk #4 succeeded at 100 (offset -5 lines).
Hunk #5 succeeded at 113 (offset -5 lines).
Hunk #6 succeeded at 129 (offset -5 lines).
Hunk #7 succeeded at 154 (offset -6 lines).
Hunk #8 succeeded at 245 (offset -9 lines).
Hunk #9 succeeded at 255 (offset -9 lines).
Hunk #10 succeeded at 271 (offset -9 lines).
Hunk #11 succeeded at 322 (offset -9 lines).
Hunk #12 succeeded at 361 (offset -11 lines).
Hunk #13 succeeded at 461 (offset -11 lines).
Hunk #14 FAILED at 522.
2 out of 14 hunks FAILED -- saving rejects to file scripts/admin.py.rej
patching file scripts/tests/admin.py
Hunk #1 succeeded at 20 (offset -7 lines).
Hunk #2 succeeded at 94 (offset -6 lines).
Hunk #3 succeeded at 105 (offset -6 lines).
patching file scripts/tests/admin-tests.txt
Hunk #1 succeeded at 6 with fuzz 2.
patching file perm.py
Hunk #1 succeeded at 19 (offset -5 lines).
Hunk #2 succeeded at 161 (offset -5 lines).
Hunk #3 succeeded at 175 (offset -5 lines).
Hunk #4 succeeded at 288 (offset -5 lines).
patching file wiki/api.py
Hunk #1 FAILED at 32.
Hunk #2 succeeded at 165 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file wiki/api.py.rej
tups:~/trac-0.9b1/trac#

Attachments (0)

Change History (4)

comment:1 Changed 9 years ago by athomas

  • Status changed from new to assigned

The refactor patch is rather sensitive to changes all through Trac, so it's not that surprising. Try the other patch.

Note: DiscussionPlugin is not actually working, but it will give you an idea of how it works.

comment:2 Changed 9 years ago by leiss

With the other patch, there is also an error:

patching file scripts/admin.py
Hunk #1 FAILED at 39.
...

Ok, I assumed that the DiscussionPlugin would not work in this development version. In future it will be a very useful enhancement to Trac.

comment:3 Changed 9 years ago by athomas

  • milestone 0.9 deleted

Milestone 0.9 deleted

comment:4 Changed 8 years ago by athomas

  • Resolution set to wontfix
  • Status changed from assigned to closed

This patch has been deprecated. DiscussionPlugin will use t:WebAdmin.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.