Modify

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#5351 closed defect (worksforme)

Incorrect author in timeline and log - GitPlugin shows committer instead of author

Reported by: egagnon@… Owned by: hvr
Priority: normal Component: GitPlugin
Severity: normal Keywords:
Cc: peter@… Trac Release: 0.12

Description

When the author differs from the committer, GitPlugin seems to favor the committer over the author as "Trac Author". This has impact in the timeline, log, and various other locations.

GitPlugin seems to have this concept of "Trac Author" in addition to "git-author" and "git-committer", as can be seen on: http://sablecc.org/changeset/1a3b6173986aa9cfc694acba0ecbbb7e40028f22

There might be reasons why a project would like to show the committer name, instead of the author name, in the timeline and log to show committer activity. Yet, other projects might have very few, or even a single committer in their official repository, as encouraged by Git. In such a case, it might make more sense to show the real author name in the timeline and log.

I suggest using a configuration flag to chose which of the git-author or git-committer to use as "Trac Author", so that everybody is pleased.

Attachments (3)

pass_repo.patch (3.4 KB) - added by roadrunner 5 years ago.
A small preparatory change
trac_author.patch (2.5 KB) - added by roadrunner 5 years ago.
Add trac_author config option
0001-Return-email-address-if-trac_user_rlookup-fails.patch (1.0 KB) - added by peter@… 4 years ago.
Return email address if trac_user_rlookup fails

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by roadrunner

I'm attaching two patches that provide a configuration option for
this. The first patch just sets up a couple things (and is identical
to the first patch for #2685); the second is the main change, and
provides a trac_author config option which defaults to 'committer'
(i.e. the original behaviour).

Changed 5 years ago by roadrunner

A small preparatory change

Changed 5 years ago by roadrunner

Add trac_author config option

comment:2 follow-up: Changed 5 years ago by anonymous

Thanks!

How should I go about testing this? I currently use "apt-get trac-git" on Debian.

comment:3 in reply to: ↑ 2 Changed 5 years ago by roadrunner

Replying to anonymous:

How should I go about testing this? I currently use "apt-get
trac-git" on Debian.

I don't know what that exactly installs (just the egg, or the expanded
egg?). But you can check out the plugin from subversion or grab the
zipped source for the plugin (see the links on the GitPlugin page),
and then do something like

cd gitplugin/0.11
patch -p2 < .../pass_repo.patch
patch -p2 < .../trac_author.patch
easy_install .

This may overwrite the installed git-plugin files from you Debian
package (and in fact you probably want to remove the Debian package
first to avoid conflicts and confusion).

comment:4 Changed 4 years ago by anonymous

Could this please be integrated in the trunk?

comment:5 Changed 4 years ago by peter@…

  • Cc peter@… added

This change does look good. I would also like to see it included in the plugin.

comment:6 Changed 4 years ago by hvr

  • Resolution set to worksforme
  • Status changed from new to closed

fyi, a slightly different imeplementation has been implemented in 1e8a1470527d24aa23c99bd10afcfca224115943

comment:7 Changed 4 years ago by anonymous

  • Trac Release changed from 0.11 to 0.12

Changed 4 years ago by peter@…

Return email address if trac_user_rlookup fails

comment:8 Changed 4 years ago by peter@…

Perfect! :) I'd like to suggest also the patch I just attached, to fall back onto only the email address if no rlookup match is found.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.