global name 'body' is not defined

I had to fix this yesterday. Got things working by commenting out that chunk of code. I'm amazed that it works for anyone else with this issue.

--- announcerplugin/distributors/email_distributor.py   (revision 6703)
+++ announcerplugin/distributors/email_distributor.py   (working copy)
@@ -282,12 +282,12 @@
                     to_unicode(provided_headers[key])
         rootMessage['Date'] = formatdate()
         # sanity check
-        if not self._charset.body_encoding:
-            try:
-                dummy = body.encode('ascii')
-            except UnicodeDecodeError:
-                raise TracError(_("Ticket contains non-ASCII chars. " \
-                                  "Please change encoding setting"))
+        #if not self._charset.body_encoding:
+        #    try:
+        #        # dummy = body.encode('ascii')
+        #    except UnicodeDecodeError:
+        #        raise TracError(_("Ticket contains non-ASCII chars. " \
+        #                          "Please change encoding setting"))
         del rootMessage['Content-Transfer-Encoding']
         rootMessage.set_charset(self._charset)
         rootMessage['Subject'] = Header(subject, self._charset)

A better solution would have been to set your encoding as the exception suggests.

[announcer]
mime_encoding = 'base64'

Read the description of the option:

    mime_encoding = Option('announcer', 'mime_encoding', 'base64',
        """Specifies the MIME encoding scheme for emails.
        
        Valid options are 'base64' for Base64 encoding, 'qp' for
        Quoted-Printable, and 'none' for no encoding. Note that the no encoding
        means that non-ASCII characters in text are going to cause problems
        with notifications (''since 0.10'').""")

I just got hit by this.

I agree that setting the mime_encoding is an easy fix. However, even so, it is still wrong for the plugin to just die with a Python NameError?.

The plugin should either fall back to a basic format (like the original attempt to use ascii, which is still broken) or else it should log something educational like, "Set mime_enconding in your [announcer] setting in trac.ini"

Just having a random traceback is not an elegant way to handle this configuration error.

Finally, if you fall back to a default encoding, why not fall back to a default of base64?

Replying to anonymous:

Sorry, I forgot to mention in my last comment:

My trac.ini had a default mime_encoding value of none. I didn't put that there... but that is supposed to be a valid selection (as per the docs cited above) so in my opinion this is an actual bug. The plugin is supposed to handle "none" correctly.

I'm still trying to get HTML notifications to work here... but thanks for working on this, a lot of people really want pretty-looking notifications. Not everybody appreciates courier font as much as the Trac developers :)

Yeah, body object doesn't exist. Not sure why this code sucks. I'll fix it.

(In [7280]) Update body reference to output.

Since body isn't defined. Fixes #5538

(In [7280]) Update body reference to output.

Since body isn't defined. Fixes #5538

(In [7589]) updates body reference to output.

Since body isn't defined. Fixes #5538 merge -r7280