Modify

Opened 8 years ago

Closed 8 years ago

#559 closed defect (fixed)

Invalid link expansion

Reported by: eblot Owned by: pkropf
Priority: high Component: GraphvizPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.9

Description

The expand_wiki_links() method is far too restrictive.

For example, it prevents from using javascript-based URL, as the regular expression

re.search('href="(.*?)"', html_url)

silently fails, which least to a Python exception.

Attaching a patch to workaround this bug.

An typical case of failure happens if the URL in the dot graph is defined as follows:

URL="javascript:window.parent.location.href='http://...'"

Attachments (1)

expandlinks.patch (802 bytes) - added by eblot 8 years ago.
Allows Javascript URLs

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by eblot

Allows Javascript URLs

comment:1 Changed 8 years ago by eblot

(sorry about not submitting a patch against the very last release of graphviz, trac-hacks is in trouble with https so I can't update my working copy through an http proxy. Nevertheless, the patch has been actually written against the latest zipped copy of graphviz)

comment:2 Changed 8 years ago by eblot

#560 to see why javascript URL is an important feature to support.

comment:3 Changed 8 years ago by pkropf

  • Resolution set to fixed
  • Status changed from new to closed

(In [1134]) Added support for javascript URLs. Fixes #559.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from pkropf. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.