From header encoded incorrectly

[Erik M. Bray]

According to RFC 5322 only the display name and the local part of the e-mail address in the From header can be quoted strings. But the announcer pluguin currently tries to encode the entire string of "display-name" <local@domain> which will break. You end up with everything up to the @ encoded, including the left angle bracket, which is incorrect.

The fix should look something like this:

announcerplugin/distributors/email_distributor.py

@@ -291 +291 @@
         del rootMessage['Content-Transfer-Encoding']
         rootMessage.set_charset(self._charset)
         rootMessage['Subject'] = Header(subject, self._charset) 
-        from_header = '"%s" <%s>'%(self.smtp_from_name or proj_name, 
-                self.smtp_from)
+        from_header = '"%s" <%s>' % \
+                      (Header(self.smtp_from_name or proj_name, self._charset),
+                       self.smtp_from)
         rootMessage['From'] = from_header
         if self.smtp_always_bcc:
             rootMessage['Bcc'] = self.smtp_always_bcc

[Robert Corsaro]

(In [7141]) From header encoding canonized fixes #5679 Thanks ebray!