# Ticket #5682 (closed enhancement: fixed)

Opened 4 years ago

## Announcer should have a page listing all Watched items

Reported by: Assigned to: anonymous doki_pen high AnnouncerPlugin normal 0.11

### Description

If this functionality can't be duplicated/merged, please change the wording of "Watch This"/"Unwatch This" to something that doesn't closely match the wording used in the WatchlistPlugin. Perhaps "Add to Announcements" or "Remove from Announcements" or something similar.

See #4744 for this workaround.

## Change History

### (follow-up: ↓ 3 ) 08/20/09 12:32:49 changed by rjollos

It would be nice put an entry in the metanav ('Watchlist') that links to the page with the table of all watched pages for a particular user.

I second this

### (in reply to: ↑ 1 ; follow-up: ↓ 7 ) 10/24/09 00:50:53 changed by martin_s

It would be nice put an entry in the metanav ('Watchlist') that links to the page with the table of all watched pages for a particular user.

This is exactly what the WatchlistPlugin does.

### 10/24/09 03:56:07 changed by martin_s

• priority changed from normal to high.

The WatchlistPlugin rev.[6834] now actively supports the AnnouncerPlugin (see #4744) and allows to switch notification of wikis and tickets watched by the WatchlistPlugin on or off. This is not exactly the same as requested by this ticket but it comes close. Please note that wikis/tickets can be independently watched by both plugins.

I agree with the ticket creator that the navbar entries "Watch This"/"Unwatch This" would be changed to someting else not including 'watch', because this is to close to the WatchlistPlugin (uses "Watch"/"Unwatch"). Maybe having it configurable by the trac.ini config, so it can be changed by people which want to use both plugins?

### 10/24/09 21:05:38 changed by doki_pen

I would accept that patch

### 10/29/09 02:08:11 changed by martin_s

Patch to make context navigation entries ('Watch this','Unwatch this') configurable

### 10/29/09 02:15:04 changed by martin_s

• status changed from new to assigned.
• owner changed from doki_pen to martin_s.

The attached patch allows the user (Trac admin) to rename or disable the context navigation entries.

## Examples

Rename the cxtnav entries:

[announcer]
ctxtnav_names = Notify me, Do not notify me


Disable the entries:

[announcer]
ctxtnav_names =


### (in reply to: ↑ 3 ) 10/29/09 02:18:28 changed by rjollos

This is exactly what the WatchlistPlugin does.

If these are two plugin are working nicely together now, that will be great! I will try installing the WatchListPlugin? shortly. I have been using the AnnouncerPlugin for 6 months.

### 10/29/09 03:43:47 changed by doki_pen

• status changed from assigned to closed.
• resolution set to fixed.

(In [6916]) Allow the ctxnav names for "watch/unwatch this" to be relabeled or shut off (by setting to blank). This patch was contributed by martin_s closes #5682

### 10/29/09 03:45:51 changed by anonymous

Thanks for the patch, I really appreciate it.

### (follow-up: ↓ 12 ) 10/29/09 07:49:43 changed by rjollos

I'm working on upgrading to install this patch and I added this change to the wiki page to document the configuration parameter. Please correct if this could be documented better.

Thanks!

### (in reply to: ↑ 11 ) 10/29/09 08:35:53 changed by martin_s

I'm working on upgrading to install this patch and I added this change to the wiki >page to document the configuration parameter. Please correct if this could be documented >better.

### 10/29/09 09:47:25 changed by martin_s

• status changed from closed to reopened.
• resolution deleted.

Sorry, I got the indexes wrong therefore the ctxtnav item names are swapped at the moment.

Either change the order of the names in the documentation or fix the indexes in the source code. I would prefer the latter because it is more natural to specify the 'Watch' action name before the 'Unwatch' one.

Simply replaces index [0] with [1] and vice versa:

===================================================================
--- subscribers/watchers.py	(revision 6916)
+++ subscribers/watchers.py	(working copy)
@@ -150,9 +150,9 @@
realm, resource = resource.split('/', 1)
if self.is_watching(req.session.sid, not req.authname == 'anonymous',
realm, resource):
+            action_name = self.ctxtnav_names[1]
+        else:
action_name = self.ctxtnav_names[0]
-        else:
-            action_name = self.ctxtnav_names[1]
tag.a(
action_name, href=req.href.watch(realm, resource)


### 10/29/09 09:54:12 changed by martin_s

Patch to fix wrong index order and rename notifications.

### 10/29/09 10:00:14 changed by martin_s

In my opinion the messages "You are now watching this resource for changes." and "You are no longer watching this resource for changes." should also be changed, so that the user is not confusing this with the addition and removal from the watchlist.

I made this changes in the attachment:announcer_ctxtnav_config2.patch .

### 10/29/09 13:22:40 changed by martin_s

• owner changed from martin_s to doki_pen.
• status changed from reopened to new.

### 11/14/09 07:01:41 changed by doki_pen

• status changed from new to closed.
• resolution set to fixed.

(In [7138]) reverse ctxtnames and check for exist fixes #5682

### Add/Change #5682 (Announcer should have a page listing all Watched items)

Change Properties