Modify

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#5858 closed defect (fixed)

Code inserted is not XHTML valid

Reported by: mitar Owned by: daveappendix
Priority: normal Component: TimelineUserFilterPlugin
Severity: normal Keywords:
Cc: mmitar@… Trac Release: 0.11

Description

Code inserted is not XHTML valid. Around <label> should be a <div>. Fix is simple, just add tag.div(...) around result in _user_field_input:

   def _user_field_input(self, req):
        return tag.div(tag.label("Filter users: ",
                         tag.input(type="text",
                                   name="users",
                                   value=req.args.get('users', ''),
                                   style_="width:60%")))

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by asic_druide

  • Resolution set to fixed
  • Status changed from new to closed

Attached version fixes #5400, #5421 and #5858.

comment:2 Changed 4 years ago by daveappendix

(In [7595]) Patch from asic_druide to fix #5400, #5421 and #5858. Thanks!

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from daveappendix. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.