Ticket #5858 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Code inserted is not XHTML valid

Reported by: mitar Assigned to: daveappendix
Priority: normal Component: TimelineUserFilterPlugin
Severity: normal Keywords:
Cc: mmitar@gmail.com Trac Release: 0.11

Description

Code inserted is not XHTML valid. Around <label> should be a <div>. Fix is simple, just add tag.div(...) around result in _user_field_input: 

   def _user_field_input(self, req):
        return tag.div(tag.label("Filter users: ",
                         tag.input(type="text",
                                   name="users",
                                   value=req.args.get('users', ''),
                                   style_="width:60%")))

Attachments

Change History

02/11/10 14:56:25 changed by asic_druide

  • status changed from new to closed.
  • resolution set to fixed.

Attached version fixes #5400, #5421 and #5858.

02/15/10 10:17:15 changed by daveappendix

(In [7595]) Patch from asic_druide to fix #5400, #5421 and #5858. Thanks!

Add/Change #5858 (Code inserted is not XHTML valid)




Change Properties
Action