Modify

Opened 5 years ago

Closed 5 years ago

#5870 closed defect (fixed)

ignoring everything that can occur during login request is a bad idea

Reported by: techtonik Owned by: pedro
Priority: normal Component: NoAnonymousPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Right now NoAnonymousPlugin is written so that it ignores any exceptions that occur during login phase. This is probably a bad idea.

source:noanonymousplugin/0.11/noanonymous/filter.py@4369

  • noanonymous/filter.py

     
    3232        except RequestDone: 
    3333            # Reraise on redirect 
    3434            raise 
    35         except Exception: 
    36             # It is possible the error we got called on happened inside 
    37             # the _get_panels call. Be sure to ignore it. 
    38             pass 
    3935 
    40         return template, data, content_type 
    41  No newline at end of file 
     36        return template, data, content_type 

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by techtonik

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r6611.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.