[Patch] Configuration parameters `from_email` and `from_name` are ignored

[rjollos]

In the [fullblog-notification] section of trac.ini, if from_name contains whitespace, only the portion preceding the whitespace appears in the email subject line.

For example with the following configuration,

from_name = My Trac Blog
subject_template = $prefix $blog.title $action

The subject line appears as,

[My] Test Post post_updated;

See also #6006 for other requested formatting improvements in the subject line.

[rjollos]

There seems to be another problem here. The FullBlogNotificationEmail.notify method calls ​NotifyEmail.notify, which sets from_email and from_name using the config options from the notification section. Therefore, the settings from the [fullblog-notification] are overwritten.

[rjollos]

I'm no longer seeing the original issue. What I am seeing is what is noted in comment:2, so I will provide a patch for that. The patch probably needs a bit more work, but seems to be working at the moment.

[rjollos]

Reassigning ticket since I am now maintainer of the plugin.

[rjollos]

This is probably the last bug to be fixed with the FullBlogNotificationPlugin, and then the focus will be on enhancing the FullBlogAnnouncementsPlugin.

Though if there are any straightforward fixes/enhancements, or patches submitted, then I will update this plugin.

[rjollos]

It appears that we can probably just remove the following configuration directives from the [fullblog-notification] section, as they are redundant with what is implemented in the [notification] section.

from_email = trac+blog@localhost
from_name = None
smtp_always_cc = []

[rjollos]

Plugin is deprecated.