Modify

Opened 5 years ago

Closed 2 years ago

#6007 closed defect (wontfix)

[Patch] Configuration parameters `from_email` and `from_name` are ignored

Reported by: rjollos Owned by: rjollos
Priority: normal Component: FullBlogNotificationPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

In the [fullblog-notification] section of trac.ini, if from_name contains whitespace, only the portion preceding the whitespace appears in the email subject line.

For example with the following configuration,

from_name = My Trac Blog
subject_template = $prefix $blog.title $action

The subject line appears as,

[My] Test Post post_updated;

See also #6006 for other requested formatting improvements in the subject line.

Attachments (1)

notification.patch (2.3 KB) - added by rjollos 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by rjollos

  • Summary changed from If `from_name` contains whitespace, only the portion preceding the whitespace appears in the email subject line to If `from_name` parameter contains whitespace, only the text preceding the whitespace appears in the email subject line

comment:2 Changed 5 years ago by rjollos

There seems to be another problem here. The FullBlogNotificationEmail.notify method calls NotifyEmail.notify, which sets from_email and from_name using the config options from the notification section. Therefore, the settings from the [fullblog-notification] are overwritten.

comment:3 Changed 5 years ago by rjollos

  • Summary changed from If `from_name` parameter contains whitespace, only the text preceding the whitespace appears in the email subject line to [Patch] Configuration parameters `from_email` and `from_name` are ignored

I'm no longer seeing the original issue. What I am seeing is what is noted in comment:2, so I will provide a patch for that. The patch probably needs a bit more work, but seems to be working at the moment.

Changed 5 years ago by rjollos

comment:4 Changed 5 years ago by rjollos

  • Owner changed from trickie to rjollos

Reassigning ticket since I am now maintainer of the plugin.

comment:5 Changed 4 years ago by rjollos

This is probably the last bug to be fixed with the FullBlogNotificationPlugin, and then the focus will be on enhancing the FullBlogAnnouncementsPlugin.

Though if there are any straightforward fixes/enhancements, or patches submitted, then I will update this plugin.

comment:6 Changed 4 years ago by rjollos

It appears that we can probably just remove the following configuration directives from the [fullblog-notification] section, as they are redundant with what is implemented in the [notification] section.

from_email = trac+blog@localhost
from_name = None
smtp_always_cc = []

comment:7 Changed 2 years ago by rjollos

  • Resolution set to wontfix
  • Status changed from new to closed

Plugin is deprecated.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.