Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6019 closed defect (fixed)

ExtractUrlPlugin does not handle paths `/path` as links

Reported by: mitar Owned by: martin_s
Priority: normal Component: ExtractUrlPlugin
Severity: normal Keywords:
Cc: mmitar@… Trac Release: 0.11

Description

ServerSideRedirectPlugin assumes it is default plugin/handler so [redirect(/)] in WikiStart page does not redirect to home (when home is handler by non-wiki plugin). ServerSideRedirectPlugin detects this as a loop.

Attachments (0)

Change History (8)

comment:1 Changed 5 years ago by martin_s

  • Status changed from new to assigned

Took me a while to understand what I meant. The plugin does not assume it is the default handler, in fact it rejects to handle anything per se. It replaces the WikiHandler (and only it) using a pre-handle request filter.

What is assumed is that the WikiHandler is the default handler for the / location, but not by this plugin but from my other plugin ExtractUrlPlugin which is used to resolve the given URLs.

I will fix this ASAP.

comment:2 follow-up: Changed 5 years ago by martin_s

  • Component changed from ServerSideRedirectPlugin to ExtractUrlPlugin
  • Resolution set to fixed
  • Status changed from assigned to closed
  • Summary changed from ServerSideRedirectPlugin assumes it is default plugin to ExtractUrlPlugin does not handle paths `/path` as links

Fixed in #6813 of the ExtractUrlPlugin.

comment:3 in reply to: ↑ 2 Changed 5 years ago by martin_s

Sorry, wrong format, should be: [6813] of the ExtractUrlPlugin.

comment:4 Changed 5 years ago by mitar

I have updated plugin but now I am getting 'ExtractUrlMacro' object has no attribute 'get_macros' error. Probably connected to [6816]?

comment:5 follow-up: Changed 5 years ago by mitar

Now it works. But when browsing history or just after setting up a redirect it displays This page redirects to: wiki:/ for [[redirect(/)]], which is not really true.

comment:6 Changed 5 years ago by martin_s

(In [6819]) tracserversideredirect/plugin.py:: Fixed display of redirect target starting

with /. See #6019 comment:5.

comment:7 in reply to: ↑ 5 Changed 5 years ago by martin_s

Replying to mitar:

Now it works. But when browsing history or just after setting up a redirect it displays This page redirects to: wiki:/ for [[redirect(/)]], which is not really true.

I was already working on this but got interrupted by the work on the ExtractUrlPlugin and did not commit it right away.

comment:8 Changed 5 years ago by mitar

Great. Everything works now. Thanks a lot.

Add Comment

Modify Ticket

Action
as closed The owner will remain martin_s.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.