Modify

Opened 5 years ago

Last modified 19 months ago

#6160 new enhancement

TracPastePlugin: Implement TagsPlugin support

Reported by: lkraav Owned by: rjollos
Priority: normal Component: TracPastePlugin
Severity: normal Keywords:
Cc: hasienda, otaku42, ejucovy Trac Release: 0.11

Description

would be nice to be able to tag pastes right? opinions welcome.

Attachments (0)

Change History (12)

comment:1 Changed 5 years ago by rjollos

  • Cc rjollos added; anonymous removed
  • Summary changed from implement TagsPlugin support to Implement TagsPlugin support

comment:2 Changed 5 years ago by lkraav

  • Summary changed from Implement TagsPlugin support to TracPastePlugin: Implement TagsPlugin support

comment:3 Changed 3 years ago by rjollos

  • Cc hasienda otaku42 added; rjollos removed
  • Owner changed from otaku42 to rjollos
  • Status changed from new to assigned

I'll be finishing up implementation of this in the next day or so and will be requesting some feedback on the patch.

comment:4 Changed 3 years ago by rjollos

I received an email with:


Comment (by lkraav):

Awesome news. Will you be basing this on top of 0.12 or 1.0?


but the comment seems to have disappeared. I'll answer anyways ;)

I'm developing again 0.11 and when I think the code is ready I test against 0.13dev (i.e. 1.0dev).

comment:5 follow-ups: Changed 3 years ago by lkraav

Yeah, I didn't notice your initial reply was for this particular feature, not the main tracker ticket I was looking at yesterday. So I didn't think my comment made much sense here :> but I guess know we know.

My main concern is the significantly changed DB API for 1.0.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 3 years ago by rjollos

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

I'm not familiar with the changed API ... I'll have to look into that. And I certainly appreciate code review after I get the feature finished ;)

comment:7 in reply to: ↑ 6 Changed 3 years ago by hasienda

Replying to rjollos:

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

I've tracked that particular development over the last months. While this is the biggest outside-facing change on the API level for Trac 0.13 aka 1.0 indeed, there is still not much to fear for plugins, since the 0.11 db API is still available. But most probably it will not survive another release cycle.

I plan to create a dedicated 1.0 branch for plugins that I maintain. Switching to the new API is not complicated, but you'll push minimum requirements up to Python2.5 due to use of the ‘with‘ statement, what is not feasible for some of the existing Trac 0.11 installations. So I do - similarly to Ryan - develop at 0.11 and upgrade to 1.0 later.

I'm not familiar with the changed API ... I'll have to look into that. And I certainly appreciate code review after I get the feature finished ;)

Will do a review too, especially appreciate another !ITagProvider implementation. Make sure to drop a hint in the TagsPlugin wiki docs, or I'll do so.

comment:8 in reply to: ↑ 5 ; follow-up: Changed 3 years ago by rjollos

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

Ticket #7204 may be related to the DB API change.

comment:9 in reply to: ↑ 8 Changed 3 years ago by hasienda

Replying to rjollos:

Ticket #7204 may be related to the DB API change.

Well, I'm sure, this IS the case.

comment:10 Changed 2 years ago by ejucovy

  • Cc ejucovy added

I'm using TracPastePlugin in production with Trac 1.0 and would love to be able to tag pastes -- I'd be happy to test this feature if a patch is available.

comment:11 Changed 2 years ago by hasienda

Note, that TagsPlugin works now with the new Trac db cursor behavior too [12069]. A dedicated branch for implementing the new Trac API will not happen before tags-0.7, the next stable plugin release.

comment:12 Changed 19 months ago by rjollos

  • Status changed from assigned to new

Add Comment

Modify Ticket

Action
as new The owner will remain rjollos.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.