Ticket #6160 (assigned enhancement)

Opened 4 years ago

Last modified 8 months ago

TracPastePlugin: Implement TagsPlugin support

Reported by: lkraav Assigned to: rjollos (accepted)
Priority: normal Component: TracPastePlugin
Severity: normal Keywords:
Cc: hasienda, otaku42, ejucovy Trac Release: 0.11

Description

would be nice to be able to tag pastes right? opinions welcome.

Attachments

Change History

11/06/09 05:31:55 changed by rjollos

  • cc set to rjollos.
  • summary changed from implement TagsPlugin support to Implement TagsPlugin support.

12/13/09 20:40:33 changed by lkraav

  • summary changed from Implement TagsPlugin support to TracPastePlugin: Implement TagsPlugin support.

06/21/12 23:57:22 changed by rjollos

  • owner changed from otaku42 to rjollos.
  • cc changed from rjollos to hasienda, otaku42.
  • status changed from new to assigned.

I'll be finishing up implementation of this in the next day or so and will be requesting some feedback on the patch.

06/22/12 09:36:18 changed by rjollos

I received an email with:

Comment (by lkraav):

Awesome news. Will you be basing this on top of 0.12 or 1.0?

but the comment seems to have disappeared. I'll answer anyways ;)

I'm developing again 0.11 and when I think the code is ready I test against 0.13dev (i.e. 1.0dev).

(follow-ups: ↓ 6 ↓ 8 ) 06/22/12 09:47:14 changed by lkraav

Yeah, I didn't notice your initial reply was for this particular feature, not the main tracker ticket I was looking at yesterday. So I didn't think my comment made much sense here :> but I guess know we know.

My main concern is the significantly changed DB API for 1.0.

(in reply to: ↑ 5 ; follow-up: ↓ 7 ) 06/22/12 09:49:03 changed by rjollos

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

I'm not familiar with the changed API ... I'll have to look into that. And I certainly appreciate code review after I get the feature finished ;)

(in reply to: ↑ 6 ) 06/23/12 20:06:25 changed by hasienda

Replying to rjollos:

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

I've tracked that particular development over the last months. While this is the biggest outside-facing change on the API level for Trac 0.13 aka 1.0 indeed, there is still not much to fear for plugins, since the 0.11 db API is still available. But most probably it will not survive another release cycle.

I plan to create a dedicated 1.0 branch for plugins that I maintain. Switching to the new API is not complicated, but you'll push minimum requirements up to Python2.5 due to use of the ‘with‘ statement, what is not feasible for some of the existing Trac 0.11 installations. So I do - similarly to Ryan - develop at 0.11 and upgrade to 1.0 later.

I'm not familiar with the changed API ... I'll have to look into that. And I certainly appreciate code review after I get the feature finished ;)

Will do a review too, especially appreciate another !ITagProvider implementation. Make sure to drop a hint in the TagsPlugin wiki docs, or I'll do so.

(in reply to: ↑ 5 ; follow-up: ↓ 9 ) 06/25/12 03:04:48 changed by rjollos

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

Ticket #7204 may be related to the DB API change.

(in reply to: ↑ 8 ) 06/25/12 20:38:59 changed by hasienda

Replying to rjollos:

Ticket #7204 may be related to the DB API change.

Well, I'm sure, this IS the case.

09/29/12 05:29:42 changed by ejucovy

  • cc changed from hasienda, otaku42 to hasienda, otaku42, ejucovy.

I'm using TracPastePlugin in production with Trac 1.0 and would love to be able to tag pastes -- I'd be happy to test this feature if a patch is available.

09/29/12 15:13:13 changed by hasienda

Note, that TagsPlugin works now with the new Trac db cursor behavior too [12069]. A dedicated branch for implementing the new Trac API will not happen before tags-0.7, the next stable plugin release.

Add/Change #6160 (TracPastePlugin: Implement TagsPlugin support)




Change Properties
Action