[Patch] Empty group file throws error

[anonymous]

If the group file is empty the following error is thrown

Trac detected an internal error:
AttributeError: 'NoneType' object has no attribute 'keys'

Most recent call last:
File "/usr/local/lib/python2.6/dist-packages/Trac-0.11.5-py2.6.egg/trac/web/main.py", line 444, in _dispatch_request
File "/usr/local/lib/python2.6/dist-packages/Trac-0.11.5-py2.6.egg/trac/web/main.py", line 205, in dispatch
File "/usr/local/lib/python2.6/dist-packages/Trac-0.11.5-py2.6.egg/trac/admin/web_ui.py", line 114, in process_request
File "build/bdist.linux-x86_64/egg/htgroupeditor/htgroupeditor.py", line 145, in render_admin_panel

It should just bring up the default screen with no selectable groups.

[Robert Rossmair]

Same here, for 0.12multirepos-r8877

[Stefan Wallentowitz]

Attached you find a patch to this.

The list is created from the file. In the POST case, that can only happen when the GET was taken before, the list cannot be empty; otherwise no POST is possible (correct?).

In the other cases (GET), the list is checked to be empty. If so, just the empty entry is added. In other cases the groups are listed as usual.

Please review it before testing.

HTH, Stefan

[Stefan Wallentowitz]

Proposed patch to this ticket

[Stefan Wallentowitz]

The previous patch had an error in using append(...) instead of concattenation. Sorry..

[Ryan J Ollos]

#8408 closed as a duplicate.

[Ryan J Ollos]

Replying to wallento:

Attached you find a patch to this.

Patch looks great. Sorry it took so long for us to get this applied!

[Ryan J Ollos]

(In [13122]) Refs #6249: Avoid traceback when the htgroups file is empty. Patch by wallento.