Ticket #6259 (assigned enhancement)

Opened 2 years ago

Last modified 6 months ago

Email address should be a mailto link

Reported by: matt.caron@sixnet.com Assigned to: hasienda (accepted)
Priority: normal Component: UserManagerPlugin
Severity: minor Keywords: permission email obfuscation
Cc: Trac Release: 0.11

Description

The email addresses displayed in the macros should be mailto links, so I can just click on them and my system does what it should.

Attachments

um_email_links.patch.zip (0.7 kB) - added by matt.caron@sixnet.com on 11/25/09 17:07:01.
Patch to make email addresses links (zip to fool anti-spam filter)
um_email_links.patch (1.3 kB) - added by lkraav on 03/22/10 11:19:55.
re-uploading without zip

Change History

11/25/09 17:07:01 changed by matt.caron@sixnet.com

  • attachment um_email_links.patch.zip added.

Patch to make email addresses links (zip to fool anti-spam filter)

03/22/10 11:19:55 changed by lkraav

  • attachment um_email_links.patch added.

re-uploading without zip

(follow-up: ↓ 2 ) 03/22/10 11:57:19 changed by lkraav

this patch works well, any particular reason why it isn't in trunk?

perhaps one could tie this with EMAIL_VIEW, too, somehow?

(in reply to: ↑ 1 ) 11/19/11 22:32:59 changed by hasienda

  • keywords set to permission email obfuscation.
  • owner changed from cbalan to hasienda.
  • status changed from new to assigned.

Replying to lkraav:

this patch works well, any particular reason why it isn't in trunk?

Yes, the author is still interested but busy with other stuff (told me so recently).

perhaps one could tie this with EMAIL_VIEW, too, somehow?

You mean permission-dependent address formatting (truncating)? This would be Chrome.format_author in trac.web.chrome, right? In general, yes, this should be there for privacy and consistency with Trac core.

In it's current state most of UM is for TRAC_ADMIN users only, so there would be no visible effect, since the top permission inherits EMAIL_VIEW anyway. However this is about WikiMacros, so would be really sensible in the context of #9506, but at publicly available pages only.

11/19/11 23:08:17 changed by hasienda

Note: IMHO private method _get_cells() in tracusermanager.profile.macros is the best place the let email obfuscation happen. This method however has an exact duplicate method in tracusermanager.admin - most probably a place to start code re-factoring.

11/20/11 02:42:21 changed by hasienda

(In [10926]) UserManagerPlugin: Add mailto: email links in UserProfilesList output, refs #6259.

Thanks for Matt Caron's patch, extended by code to hide emails as suggested by Leho Kraav.

11/20/11 03:04:19 changed by hasienda

(In [10927]) UserManagerPlugin: Post-chance template cleanup, refs #6259.

Converting from tab to space indentation, removing mixed whitespace too.

Add/Change #6259 (Email address should be a mailto link)




Change Properties
Action