Opened 4 years ago
Last modified 19 months ago
#6259 assigned enhancement
Email address should be a mailto link
| Reported by: | matt.caron@… | Owned by: | hasienda |
|---|---|---|---|
| Priority: | normal | Component: | UserManagerPlugin |
| Severity: | minor | Keywords: | permission email obfuscation |
| Cc: | Trac Release: | 0.11 |
Description
The email addresses displayed in the macros should be mailto links, so I can just click on them and my system does what it should.
Attachments (2)
Change History (7)
Changed 4 years ago by matt.caron@…
comment:1 follow-up: ↓ 2 Changed 3 years ago by lkraav
this patch works well, any particular reason why it isn't in trunk?
perhaps one could tie this with EMAIL_VIEW, too, somehow?
comment:2 in reply to: ↑ 1 Changed 19 months ago by hasienda
- Keywords permission email obfuscation added
- Owner changed from cbalan to hasienda
- Status changed from new to assigned
Replying to lkraav:
this patch works well, any particular reason why it isn't in trunk?
Yes, the author is still interested but busy with other stuff (told me so recently).
perhaps one could tie this with EMAIL_VIEW, too, somehow?
You mean permission-dependent address formatting (truncating)? This would be Chrome.format_author in trac.web.chrome, right? In general, yes, this should be there for privacy and consistency with Trac core.
In it's current state most of UM is for TRAC_ADMIN users only, so there would be no visible effect, since the top permission inherits EMAIL_VIEW anyway. However this is about WikiMacros, so would be really sensible in the context of #9506, but at publicly available pages only.
comment:3 Changed 19 months ago by hasienda
Note: IMHO private method _get_cells() in tracusermanager.profile.macros is the best place the let email obfuscation happen. This method however has an exact duplicate method in tracusermanager.admin - most probably a place to start code re-factoring.
comment:4 Changed 19 months ago by hasienda
(In [10926]) UserManagerPlugin: Add mailto: email links in UserProfilesList output, refs #6259.
Thanks for Matt Caron's patch, extended by code to hide emails as suggested
by Leho Kraav.
comment:5 Changed 19 months ago by hasienda
(In [10927]) UserManagerPlugin: Post-chance template cleanup, refs #6259.
Converting from tab to space indentation, removing mixed whitespace too.
Patch to make email addresses links (zip to fool anti-spam filter)