[patch] Users can't get verification email

[rue@…]

I've installed the plugins and enable the all function in this plugin.Once I create new account , users can't get the verification mails. Have you met this situation?

Thanks,

[otaku42]

Make sure you have the following in your trac.ini:

[notification]
smtp_enabled = true

[anonymous]

What is confusing is that AccountChangeListener has to be enabled in order to send verification mails. The log output won’t tell much and it should exist a warning or even an error message that it isn’t possible to send verification mails when certain dependencies aren’t met.

[larsivi]

Patch to solve this issue

[larsivi]

I have attached a patch that fixes this issue (or at least it fixes how I experienced it). What happens is that the notification code assumes that the username is an email address, even if an email explicitly has been set (in fact nothing is sent if an email isn't explicitly set).

This does mean changes to the API, but totally sane ones IMO.

[larsivi]

I have created ​http://bitbucket.org/larsivi/trac-accountmanager-plugin/ as an alternative place to get this plugin and any patches I've applied (so far only this one).

[hasienda]

Replying to larsivi:

I have attached a patch that fixes this issue (or at least it fixes how I experienced it). What happens is that the notification code assumes that the username is an email address, even if an email explicitly has been set (in fact nothing is sent if an email isn't explicitly set).

Thanks for sharing your experience on the account verification feature.

I don't know, if your assertion on the AccountManagerPlugin code is true, since it worked flawlessly for me by now. However there is not only ​TracNotification but AnnouncerPlugin to be taken into account, and I've been always using the latter. I'll have to fix the high priority issues first, but I'll certainly come back at you soon.

This does mean changes to the API, but totally sane ones IMO.

Are there any relevant unittests in place. If so, did you already check them with your changes applied? If not, would you dare to create/propose some. Patch welcome, even building blocks would be certainly appreciated.

[hasienda]

I'm aware of this pending issue. But I'll have to postpone this to finally get the new release out of the door. But I'll try to resolve this within the next release cycle.

[sdhengsoft]

Hi, just reporting that I'm getting this exact problem. Adding a new user does not seem to send a verification e-mail. Getting that new user to change or update their e-mail address does send a verification e-mail. I'm also using TracNotification. I tried AnnouncePlugin but could not get that to work at all. I have now idea what the AnnouncePlugin was doing, but it would not talk over SendMail given the documentation says it can.

An interesting thing I have found is that as TRAC_ADMIN the new user appears in the user list with full name and e-mail address details. However, if you login as that new user the full name and e-mail details under the "General" preferences tab are blank. Go figure!

[sdhengsoft]

P.S. I'm using Trac 0.12, TracAccountManager 0.4dev and tried using TracAnnouncer-0.12.1dev

[hasienda]

Replying to sdhengsoft:

Hi, just reporting that I'm getting this exact problem. Adding a new user does not seem to send a verification e-mail. Getting that new user to change or update their e-mail address does send a verification e-mail.

Thanks for the confirmation. Yes, this is still unresolved, sorry.

An interesting thing I have found is that as TRAC_ADMIN the new user appears in the user list with full name and e-mail address details. However, if you login as that new user the full name and e-mail details under the "General" preferences tab are blank. Go figure!

This is also a known issue, so you may want to follow #9252 for more details and progress.

[sdhengsoft]

Thanks for the update. I'll follow #9252 as well.

[sdhengsoft]

Hey I got TracAnnounce working finally. Still no joy with verification email with newly registered users. The only way seem to get the user to update their email address manually. Then a verification e-mail is sent.

[hasienda]

Please retry with recent trunk code for both plugins, because it has been fixed in TracAnnouncer aka AnnouncerPlugin according to my recent tests. Feedback welcome.

[hasienda]

Replying to rue@ms5.hinet.net:

I've installed the plugins and enable the all function in this plugin.Once I create new account , users can't get the verification mails. Have you met this situation?

No, I can't reproduce this issue with acct_mgr-0.4 and a recent trunk revision of TracAnnouncer. TracNotification should work as well.

Please re-try to allow for progress, or I'll assume this issue has been resolved by some of the changes before aforementioned plugin release.